V280 filters out empty MSA/MDs

Nick Grippin · Nick Grippin · commit 8bcfb62ba0a3 · 2017-09-08T14:04:19.000-04:00
diff --git a/validation/src/main/scala/hmda/validation/rules/lar/validity/V280.scala b/validation/src/main/scala/hmda/validation/rules/lar/validity/V280.scala
@@ -11,9 +11,9 @@ object V280 extends EditCheck[LoanApplicationRegister] {
 
   val cbsaTracts = CBSATractLookup.values
 
-  val validMSAs = cbsaTracts.map(cbsa => cbsa.geoIdMsa).toSet
+  val validMSAs = cbsaTracts.map(cbsa => cbsa.geoIdMsa).filterNot(msa => msa.isEmpty).toSet
 
-  val validMDs = cbsaTracts.map(cbsa => cbsa.metDivFp).toSet
+  val validMDs = cbsaTracts.map(cbsa => cbsa.metDivFp).filterNot(md => md.isEmpty).toSet
 
   override def name: String = "V280"
 
diff --git a/validation/src/test/scala/hmda/validation/rules/lar/validity/V280Spec.scala b/validation/src/test/scala/hmda/validation/rules/lar/validity/V280Spec.scala
@@ -38,5 +38,13 @@ class V280Spec extends LarEditCheckSpec {
     }
   }
 
+  property("Fails for a blank MSA code") {
+    forAll(larGen) { lar =>
+      val inValidGeography = lar.geography.copy(msa = "")
+      val inValidLar = lar.copy(geography = inValidGeography)
+      inValidLar.mustFail
+    }
+  }
+
   override def check: EditCheck[LoanApplicationRegister] = V280
 }

Original file line number	Diff line number	Diff line change
`@@ -38,5 +38,13 @@ class V280Spec extends LarEditCheckSpec {`
`38`	`38`	`}`
`39`	`39`	`}`
`40`	`40`
	`41`	`+ property("Fails for a blank MSA code") {`
	`42`	`+ forAll(larGen) { lar =>`
	`43`	`+ val inValidGeography = lar.geography.copy(msa = "")`
	`44`	`+ val inValidLar = lar.copy(geography = inValidGeography)`
	`45`	`+ inValidLar.mustFail`
	`46`	`+ }`
	`47`	`+ }`
	`48`	`+`
`41`	`49`	`override def check: EditCheck[LoanApplicationRegister] = V280`
`42`	`50`	`}`