Use camelCase for json properties

Author: schbetsy

publication/src/main/scala/hmda/publication/reports/protocol/BorrowerCharacteristicProtocol.scala

@@ -20,10 +20,10 @@ trait BorrowerCharacteristicProtocol extends CharacteristicProtocol {
           "ethnicities" -> ethnicities.toJson
         )
 
-      case MinorityStatusBorrowerCharacteristic(minoritystatus) =>
+      case MinorityStatusBorrowerCharacteristic(minorityStatus) =>
         JsObject(
           "characteristic" -> JsString("Minority Status"),
-          "minoritystatus" -> minoritystatus.toJson
+          "minorityStatus" -> minorityStatus.toJson
         )
 
     }
@@ -39,9 +39,9 @@ trait BorrowerCharacteristicProtocol extends CharacteristicProtocol {
           fields("ethnicities").convertTo[List[EthnicityCharacteristic]]
         )
 
-      case JsObject(fields) if fields.isDefinedAt("minoritystatus") =>
+      case JsObject(fields) if fields.isDefinedAt("minorityStatus") =>
         MinorityStatusBorrowerCharacteristic(
-          fields("minoritystatus").convertTo[List[MinorityStatusCharacteristic]]
+          fields("minorityStatus").convertTo[List[MinorityStatusCharacteristic]]
         )
     }
 

publication/src/main/scala/hmda/publication/reports/protocol/MSAReportProtocol.scala

@@ -12,20 +12,20 @@ trait MSAReportProtocol extends DefaultJsonProtocol {
         "id" -> JsString(obj.id),
         "name" -> JsString(obj.name),
         "state" -> JsString(obj.state),
-        "state_name" -> JsString(obj.stateName)
+        "stateName" -> JsString(obj.stateName)
       )
     }
 
     override def read(json: JsValue): MSAReport = json match {
       case JsObject(fields) if fields.isDefinedAt("id")
         & fields.isDefinedAt("name")
         & fields.isDefinedAt("state")
-        & fields.isDefinedAt("state_name") =>
+        & fields.isDefinedAt("stateName") =>
         MSAReport(
           fields("id").convertTo[String],
           fields("name").convertTo[String],
           fields("state").convertTo[String],
-          fields("state_name").convertTo[String]
+          fields("stateName").convertTo[String]
         )
     }
   }

publication/src/main/scala/hmda/publication/reports/protocol/disclosure/D51Protocol.scala

@@ -17,29 +17,29 @@ object D51Protocol
 
     override def write(obj: D51): JsValue = {
       JsObject(
-        "respondent_id" -> JsString(obj.respondentId),
-        "institution_name" -> JsString(obj.institutionName),
+        "respondentId" -> JsString(obj.respondentId),
+        "institutionName" -> JsString(obj.institutionName),
         "table" -> JsString("5-1"),
         "type" -> JsString(Disclosure.toString),
         "desc" -> JsString(obj.description),
         "year" -> JsNumber(obj.year),
-        "report_date" -> JsString(obj.reportDate),
+        "reportDate" -> JsString(obj.reportDate),
         "msa" -> obj.msa.toJson,
-        "applicant_incomes" -> obj.applicantIncomes.toJson,
+        "applicantIncomes" -> obj.applicantIncomes.toJson,
         "total" -> obj.total.toJson
       )
     }
 
     override def read(json: JsValue): D51 = json.asJsObject.getFields(
-      "respondent_id",
-      "institution_name",
+      "respondentId",
+      "institutionName",
       "table",
       "type",
       "desc",
       "year",
-      "report_date",
+      "reportDate",
       "msa",
-      "applicant_incomes",
+      "applicantIncomes",
       "total"
     ) match {
         case Seq(respondentId, institutionName, table, reportType, description, year, reportDate, msa, applicantIncomes, total) =>

publication/src/test/scala/hmda/publication/reports/disclosure/D51ProtocolSpec.scala

@@ -17,15 +17,15 @@ class D51ProtocolSpec extends PropSpec with PropertyChecks with MustMatchers {
   property("D51 Report must serialize to the correct JSON format") {
     forAll(d51Gen) { d51 =>
       d51.toJson mustBe JsObject(
-        "respondent_id" -> JsString(d51.respondentId),
-        "institution_name" -> JsString(d51.institutionName),
+        "respondentId" -> JsString(d51.respondentId),
+        "institutionName" -> JsString(d51.institutionName),
         "table" -> JsString("5-1"),
         "type" -> JsString("Disclosure"),
         "desc" -> JsString("Disposition of applications for FHA, FSA/RHS, and VA home-purchase loans, 1- to 4-family and manufactured home dwellings, by income, race and ethnicity of applicant"),
         "year" -> JsNumber(d51.year),
-        "report_date" -> JsString(d51.reportDate),
+        "reportDate" -> JsString(d51.reportDate),
         "msa" -> d51.msa.toJson,
-        "applicant_incomes" -> d51.applicantIncomes.toJson,
+        "applicantIncomes" -> d51.applicantIncomes.toJson,
         "total" -> d51.total.toJson
       )
     }