Calculate actor ref every time and persiste IRS stats immediately

Author: Nick Grippin

persistence/src/main/scala/hmda/persistence/processing/HmdaFileValidator.scala

@@ -115,7 +115,7 @@ class HmdaFileValidator(submissionId: SubmissionId) extends HmdaPersistentActor
 
   val supervisor = system.actorSelection("/user/supervisor")
   val fHmdaFiling = (supervisor ? FindHmdaFiling(submissionId.period)).mapTo[ActorRef]
-  val statRef = for {
+  def statRef = for {
     manager <- (supervisor ? FindProcessingActor(SubmissionManager.name, submissionId)).mapTo[ActorRef]
     stat <- (manager ? GetActorRef(SubmissionLarStats.name)).mapTo[ActorRef]
   } yield stat
@@ -256,13 +256,6 @@ class HmdaFileValidator(submissionId: SubmissionId) extends HmdaPersistentActor
 
     case CompleteValidation(replyTo, originalSender) =>
       if (state.readyToSign) {
-        log.info("Ready to persist IRS")
-        for {
-          stat <- statRef
-        } yield {
-          log.info(s"Sending IRS persistence message to SubmissionLarStats: $stat")
-          stat ! PersistIrs
-        }
         log.debug(s"Validation completed for $submissionId")
         replyTo ! ValidationCompleted(originalSender)
       } else {

validation/src/main/scala/hmda/validation/SubmissionLarStats.scala

@@ -124,16 +124,16 @@ class SubmissionLarStats(submissionId: SubmissionId) extends HmdaPersistentActor
           q075Ratio,
           q076Ratio
         )
+        self ! PersistIrs
         validationStats ! msg
       }
 
     case PersistIrs =>
       val msaSeq = msaMap.msas.values.toSeq
-      log.info("PersistIrs message received at SubmissionLarStats, about to persist IRS")
       persist(IrsStatsUpdated(msaSeq)) { e =>
+        log.debug(s"Persisted: $msaSeq")
         updateState(e)
         val validationStats = context.actorSelection("/user/validation-stats")
-        log.info(s"Persisted: $msaSeq, sending message to ValidationStats: $validationStats")
         validationStats ! AddIrsStats(msaSeq, submissionId)
       }
 

validation/src/main/scala/hmda/validation/ValidationStats.scala

@@ -134,9 +134,8 @@ class ValidationStats extends HmdaPersistentActor {
       }
 
     case AddIrsStats(map, id) =>
-      log.info("ValidationStats AddIrsStats message received")
       persist(IrsStatsAdded(map, id)) { e =>
-        log.info(s"Persisted: $e")
+        log.debug(s"Persisted: $e")
         updateState(e)
       }
 
@@ -147,8 +146,6 @@ class ValidationStats extends HmdaPersistentActor {
       sender ! state.latestStatsFor(id, period).totalValidatedLars
 
     case FindIrsStats(subId) =>
-      log.info(s"Finding IRS Stats for $subId")
-      log.info(s"Current stats are ${state.stats}")
       val stats = state.stats.find(s => s.id == subId).getOrElse(SubmissionStats(subId))
       sender ! stats.msas