Skip to content

Commit de15de4

Browse files
jimcziomricohenn
authored andcommitted
Fix invalid setting value in ShardBulkInferenceActionFilter tests (elastic#125006)
0 is not a valid value. Closes elastic#124985 Closes elastic#124986 Closes elastic#124955 Closes elastic#124954
1 parent fc5894a commit de15de4

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

muted-tests.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -360,12 +360,6 @@ tests:
360360
- class: org.elasticsearch.xpack.ilm.DataStreamAndIndexLifecycleMixingTests
361361
method: testIndexTemplateSwapsILMForDataStreamLifecycle
362362
issue: https://github.com/elastic/elasticsearch/issues/124886
363-
- class: org.elasticsearch.xpack.inference.action.filter.ShardBulkInferenceActionFilterTests
364-
method: testExplicitNull {p0=false}
365-
issue: https://github.com/elastic/elasticsearch/issues/124891
366-
- class: org.elasticsearch.xpack.inference.action.filter.ShardBulkInferenceActionFilterTests
367-
method: testExplicitNull {p0=true}
368-
issue: https://github.com/elastic/elasticsearch/issues/124892
369363
- class: org.elasticsearch.packaging.test.BootstrapCheckTests
370364
method: test20RunWithBootstrapChecks
371365
issue: https://github.com/elastic/elasticsearch/issues/124940

x-pack/plugin/inference/src/internalClusterTest/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilterIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public void setup() throws Exception {
8787

8888
@Override
8989
protected Settings nodeSettings(int nodeOrdinal, Settings otherSettings) {
90-
long batchSizeInBytes = randomLongBetween(0, ByteSizeValue.ofKb(1).getBytes());
90+
long batchSizeInBytes = randomLongBetween(1, ByteSizeValue.ofKb(1).getBytes());
9191
return Settings.builder()
9292
.put(otherSettings)
9393
.put(LicenseSettings.SELF_GENERATED_LICENSE_TYPE.getKey(), "trial")

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilterTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,7 @@ private static ClusterService createClusterService(boolean useLegacyFormat) {
567567
ClusterState clusterState = ClusterState.builder(new ClusterName("test")).metadata(metadata).build();
568568
ClusterService clusterService = mock(ClusterService.class);
569569
when(clusterService.state()).thenReturn(clusterState);
570-
long batchSizeInBytes = randomLongBetween(0, ByteSizeValue.ofKb(1).getBytes());
570+
long batchSizeInBytes = randomLongBetween(1, ByteSizeValue.ofKb(1).getBytes());
571571
Settings settings = Settings.builder().put(INDICES_INFERENCE_BATCH_SIZE.getKey(), ByteSizeValue.ofBytes(batchSizeInBytes)).build();
572572
when(clusterService.getSettings()).thenReturn(settings);
573573
when(clusterService.getClusterSettings()).thenReturn(new ClusterSettings(settings, Set.of(INDICES_INFERENCE_BATCH_SIZE)));

0 commit comments

Comments
 (0)