Remove remoteAddress field from TransportResponse (elastic#120016)

This field is only used (by security) for requests, having it in responses is redundant.
Also, we have a couple of responses that are singletons/quasi-enums where setting the value
needlessly might introduce some strange contention even though it's a plain store.

This isn't just a cosmetic change. It makes it clear at compile time that each response instance
is exclusively defined by the bytes that it is read from. This makes it easier to reason about the
validity of suggested optimizations like elastic#120010

Author: original-brownbear

modules/data-streams/src/main/java/org/elasticsearch/datastreams/lifecycle/action/GetDataStreamLifecycleStatsAction.java

@@ -67,7 +67,6 @@ public Response(@Nullable Long runDuration, @Nullable Long timeBetweenStarts, Li
         }
 
         public Response(StreamInput in) throws IOException {
-            super(in);
             this.runDuration = in.readOptionalVLong();
             this.timeBetweenStarts = in.readOptionalVLong();
             this.dataStreamStats = in.readCollectionAsImmutableList(DataStreamStats::read);

modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/GrokProcessorGetAction.java

@@ -96,7 +96,6 @@ public static class Response extends ActionResponse implements ToXContentObject
         }
 
         Response(StreamInput in) throws IOException {
-            super(in);
             grokPatterns = in.readMap(StreamInput::readString);
         }
 

modules/lang-painless/src/main/java/org/elasticsearch/painless/action/PainlessExecuteAction.java

@@ -463,7 +463,6 @@ public static class Response extends ActionResponse implements ToXContentObject
         }
 
         Response(StreamInput in) throws IOException {
-            super(in);
             result = in.readGenericValue();
         }
 

modules/rank-eval/src/main/java/org/elasticsearch/index/rankeval/RankEvalResponse.java

@@ -44,7 +44,6 @@ public RankEvalResponse(double metricScore, Map<String, EvalQueryQuality> partia
     }
 
     RankEvalResponse(StreamInput in) throws IOException {
-        super(in);
         this.metricScore = in.readDouble();
         int partialResultSize = in.readVInt();
         this.details = Maps.newMapWithExpectedSize(partialResultSize);

server/src/internalClusterTest/java/org/elasticsearch/action/admin/cluster/node/tasks/CancellableTasksIT.java

@@ -495,9 +495,7 @@ public TestResponse() {
 
         }
 
-        public TestResponse(StreamInput in) throws IOException {
-            super(in);
-        }
+        public TestResponse(StreamInput in) {}
 
         @Override
         public void writeTo(StreamOutput out) throws IOException {

server/src/internalClusterTest/java/org/elasticsearch/search/rank/MockedRequestActionBasedRerankerIT.java

@@ -197,11 +197,6 @@ public TestRerankingActionResponse(List<Float> scores) {
             this.scores = scores;
         }
 
-        public TestRerankingActionResponse(StreamInput in) throws IOException {
-            super(in);
-            this.scores = in.readCollectionAsList(StreamInput::readFloat);
-        }
-
         @Override
         public void writeTo(StreamOutput out) throws IOException {
             out.writeCollection(scores, StreamOutput::writeFloat);

server/src/main/java/org/elasticsearch/action/ActionResponse.java

@@ -9,25 +9,18 @@
 
 package org.elasticsearch.action;
 
-import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.common.io.stream.StreamOutput;
 import org.elasticsearch.transport.TransportResponse;
 import org.elasticsearch.xcontent.ToXContentObject;
 import org.elasticsearch.xcontent.XContentBuilder;
 
-import java.io.IOException;
-
 /**
  * Base class for responses to action requests.
  */
 public abstract class ActionResponse extends TransportResponse {
 
     public ActionResponse() {}
 
-    public ActionResponse(StreamInput in) throws IOException {
-        super(in);
-    }
-
     public static final class Empty extends ActionResponse implements ToXContentObject {
         public static final ActionResponse.Empty INSTANCE = new ActionResponse.Empty();
 

server/src/main/java/org/elasticsearch/action/admin/cluster/allocation/ClusterAllocationExplainResponse.java

@@ -26,7 +26,6 @@ public class ClusterAllocationExplainResponse extends ActionResponse implements
     private final ClusterAllocationExplanation cae;
 
     public ClusterAllocationExplainResponse(StreamInput in) throws IOException {
-        super(in);
         this.cae = new ClusterAllocationExplanation(in);
     }
 

server/src/main/java/org/elasticsearch/action/admin/cluster/allocation/TransportGetAllocationStatsAction.java

@@ -157,7 +157,6 @@ public Response(Map<String, NodeAllocationStats> nodeAllocationStats, DiskThresh
         }
 
         public Response(StreamInput in) throws IOException {
-            super(in);
             this.nodeAllocationStats = in.readImmutableMap(StreamInput::readString, NodeAllocationStats::new);
             if (in.getTransportVersion().onOrAfter(TransportVersions.V_8_15_0)) {
                 this.diskThresholdSettings = in.readOptionalWriteable(DiskThresholdSettings::readFrom);

server/src/main/java/org/elasticsearch/action/admin/cluster/coordination/ClusterFormationInfoAction.java

@@ -81,7 +81,6 @@ public static class Response extends ActionResponse {
         private final ClusterFormationFailureHelper.ClusterFormationState clusterFormationState;
 
         public Response(StreamInput in) throws IOException {
-            super(in);
             clusterFormationState = new ClusterFormationFailureHelper.ClusterFormationState(in);
         }