Merge pull request #113 from DanielPlainview/master

DatabaseException при отсутствии соединения

Author: dovg

core/DB/PgSQL.class.php

@@ -37,15 +37,18 @@ public function connect()
 				.($this->basename ? " dbname={$this->basename}" : null)
 				.($this->port ? " port={$this->port}" : null);
 
-			if ($this->persistent)
-				$this->link = pg_pconnect($conn);
-			else
-				$this->link = pg_connect($conn);
-
-			if (!$this->link)
+			try {
+				if ($this->persistent)
+					$this->link = pg_pconnect($conn);
+				else
+					$this->link = pg_connect($conn);
+			} catch (Exception $e) {
 				throw new DatabaseException(
-					'can not connect to PostgreSQL server: '.pg_errormessage()
+					'can not connect to PostgreSQL server: '.$e->getMessage(),
+					$e->getCode(),
+					$e
 				);
+			}
 
 			if ($this->encoding)
 				$this->setDbEncoding();

doc/ChangeLog

@@ -1,3 +1,10 @@
+2012-06-29	N. Konstantinov
+
+	* core/DB/PgSQL.class.php
+		test/core/DbConnectionTest.class.php:
+
+	throw DatabaseException instead of BaseException in case of connection's failure
+
 2012-06-27	Alexey S. Denisov
 
 	* main/Base/AbstractProtoClass.class.php

test/core/DbConnectionTest.class.php

@@ -0,0 +1,30 @@
+<?php
+
+	final class DbConnectionTest extends TestCase
+	{
+		public function setUp()
+		{
+			DBPool::me()->
+				addLink(
+					'badLink',
+					DB::spawn('PinbedPgSQL', 'postgres', '', 'localhost', 'wrongDatabase')
+				);
+		}
+		
+		public function testPostgresql()
+		{
+			try {
+				$link = DBPool::me()->getLink('badLink');
+				$this->fail('Unreachable code');
+			} catch(Exception $e) {
+				$this->assertInstanceOf('DatabaseException', $e);
+			}
+		}
+		
+		public function tearDown()
+		{
+			DBPool::me()->dropLink('badLink');
+		}
+	}
+
+?>