Merge pull request #59 from dovg/nullStringDialect

throw exception for null values

Author: dovg

core/DB/Dialect.class.php

@@ -100,17 +100,20 @@ public function toValueString($expression)
 
 		private function toNeededString($expression, $method)
 		{
+			if (null === $expression)
+				throw new WrongArgumentException(
+					'not null expression expected'
+				);
+			
 			$string = null;
 
-			if (null !== $expression) {
-				if ($expression instanceof DialectString) {
-					if ($expression instanceof Query)
-						$string .= '('.$expression->toDialectString($this).')';
-					else
-						$string .= $expression->toDialectString($this);
-				} else {
-					$string .= $this->$method($expression);
-				}
+			if ($expression instanceof DialectString) {
+				if ($expression instanceof Query)
+					$string .= '('.$expression->toDialectString($this).')';
+				else
+					$string .= $expression->toDialectString($this);
+			} else {
+				$string .= $this->$method($expression);
 			}
 
 			return $string;

doc/ChangeLog

@@ -1,3 +1,8 @@
+2012-01-11	Evgeny V. Kokovikhin
+
+	* core/DB/Dialect.class.php: throw exception for null values. Thanks to 
+	Nikita V. Konstantinov.
+
 2011-11-21      Alexey S. Denisov, Evgeny V. Kokovikhin
 
 	* meta/types/ObjectType.class.php, test/misc/DAOTest.class.php: changed logic

test/core/LogicTest.class.php

@@ -210,6 +210,14 @@ public function testBaseSqlGeneration()
 				'(- a)',
 				Expression::minus('a')->toDialectString($dialect)
 			);
+			
+			try {
+				Expression::eq('id', null)->toDialectString($dialect);
+				
+				$this->fail();
+			} catch (WrongArgumentException $e) {
+				//it's Ok
+			}
 		}
 
 		public function testPgGeneration()