Skip to content

Commit 06010a6

Browse files
authored
[SYCLomatic][CMake] Support migration of ${CUDA_cufft_LIBRARY} and refine migration of ${CMAKE_CUDA_TOOLKIT_INCLUDE_DIRECTORIES} (#2254)
Signed-off-by: chenwei.sun <[email protected]>
1 parent d4145ec commit 06010a6

File tree

4 files changed

+25
-15
lines changed

4 files changed

+25
-15
lines changed

clang/test/dpct/cmake_migration/case_039/expected.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,5 @@ add_link_options("")
3232
add_link_options("")
3333
add_link_options("")
3434
add_link_options("")
35+
target_link_libraries(dali_kernels PRIVATE ${MKL_LIB})
36+
include_directories(SYSTEM "${SYCLToolkit_LIBRARY_DIR}")

clang/test/dpct/cmake_migration/case_039/input.cmake

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,5 @@ add_link_options("--no-ptxas-options")
3232
add_link_options("--emit-ptx=output.ptx")
3333
add_link_options("--nvvmir-library=my_nvvm_library")
3434
add_link_options("--library-path=/path/to/libraries")
35+
target_link_libraries(dali_kernels PRIVATE ${CUDA_cufft_LIBRARY})
36+
include_directories(SYSTEM "${CMAKE_CUDA_TOOLKIT_INCLUDE_DIRECTORIES}")

clang/test/dpct/cmake_migration/case_054/expected.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ target_include_directories(${lib_name} SYSTEM INTERFACE "${SYCL_INCLUDE_DIR}")
77
# TransformerEngine/transformer_engine/cmake/FindCUDNN.cmake
88
target_include_directories(target $<BUILD_INTERFACE:${SYCL_INCLUDE_DIR}>)
99

10-
target_include_directories(nvshmem_device_lib INTERFACE ${SYCL_INCLUDE_DIR})
10+
target_include_directories(nvshmem_device_lib INTERFACE ${SYCLToolkit_LIBRARY_DIR})
1111

1212
target_include_directories(quda SYSTEM PUBLIC $<$<COMPILE_LANGUAGE:CXX>:${SYCL_INCLUDE_DIR}>)
1313

clang/tools/dpct/DpctOptRules/cmake_script_migration_rule.yaml

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -573,6 +573,26 @@
573573
Out: ""
574574
RuleId: "remove_CUDA_nvToolsExt_LIBRARY"
575575

576+
- Rule: rule_CUDA_cufft_LIBRARY
577+
Kind: CMakeRule
578+
Priority: Fallback
579+
MatchMode: Partial
580+
CmakeSyntax: CUDA_cufft_LIBRARY
581+
In: ${func_name}(${value})
582+
Out: ${func_name}(${value})
583+
Subrules:
584+
value:
585+
MatchMode: Full
586+
In: \${CUDA_cufft_LIBRARY}
587+
Out: \${MKL_LIB}
588+
589+
- Rule: rule_CMAKE_CUDA_TOOLKIT_INCLUDE_DIRECTORIES
590+
Kind: CMakeRule
591+
Priority: Fallback
592+
CmakeSyntax: CMAKE_CUDA_TOOLKIT_INCLUDE_DIRECTORIES
593+
In: \${CMAKE_CUDA_TOOLKIT_INCLUDE_DIRECTORIES}
594+
Out: \${SYCLToolkit_LIBRARY_DIR}
595+
576596
- Rule: rule_cuda_compile_with_opts
577597
Kind: CMakeRule
578598
Priority: Fallback
@@ -2508,20 +2528,6 @@
25082528
MatchMode: Full
25092529
RuleId: "replace_cudnn_include_dir_with_sycl_include_dir"
25102530

2511-
- Rule: rule_target_include_directories_cmake_cuda_toolkit_include_dir
2512-
Kind: CMakeRule
2513-
Priority: Fallback
2514-
CmakeSyntax: target_include_directories_cmake_cuda_toolkit_inc
2515-
MatchMode: Partial
2516-
In: target_include_directories${empty}(${value})
2517-
Out: target_include_directories(${value})
2518-
Subrules:
2519-
value:
2520-
In: CMAKE_CUDA_TOOLKIT_INCLUDE_DIRECTORIES
2521-
Out: SYCL_INCLUDE_DIR
2522-
MatchMode: Full
2523-
RuleId: "replace_cmake_cuda_toolkit_include_dir_with_sycl_include_dir"
2524-
25252531
- Rule: rule_target_include_directories_cuda_toolkit_math_include_dir
25262532
Kind: CMakeRule
25272533
Priority: Fallback

0 commit comments

Comments
 (0)