[SYCLomatic] Fix a crash issue by stopping process template arg when it is a parameter pack (#408)

Signed-off-by: Wang, Yihan <[email protected]>

Author: Yihan Wang

clang/lib/DPCT/ASTTraversal.cpp

@@ -10731,6 +10731,12 @@ void MemoryMigrationRule::mallocMigration(
 void MemoryMigrationRule::memcpyMigration(
     const MatchFinder::MatchResult &Result, const CallExpr *C,
     const UnresolvedLookupExpr *ULExpr, bool IsAssigned) {
+  for (unsigned I = 0, E = C->getNumArgs(); I != E; ++I) {
+    if (isa<PackExpansionExpr>(C->getArg(I))) {
+      return;
+    }
+  }
+
   std::string Name;
   if (ULExpr) {
     Name = ULExpr->getName().getAsString();

clang/lib/DPCT/ExprAnalysis.cpp

@@ -845,6 +845,12 @@ void ExprAnalysis::analyzeExpr(const CallExpr *CE) {
     return;
   auto Itr = CallExprRewriterFactoryBase::RewriterMap->find(RefString);
   if (Itr != CallExprRewriterFactoryBase::RewriterMap->end()) {
+    for (unsigned I = 0, E = CE->getNumArgs(); I != E; ++I) {
+      if (isa<PackExpansionExpr>(CE->getArg(I))) {
+        return;
+      }
+    }
+
     auto Rewriter = Itr->second->create(CE);
     auto Result = Rewriter->rewrite();
     BlockLevelFormatFlag = Rewriter->getBlockLevelFormatFlag();

clang/test/dpct/pack_expansion_in_arg_list.cu

@@ -0,0 +1,42 @@
+// RUN: dpct --format-range=none -out-root %T/pack_expansion_in_arg_list %s --cuda-include-path="%cuda-path/include" -- -x cuda --cuda-host-only
+// RUN: FileCheck %s --input-file %T/pack_expansion_in_arg_list/pack_expansion_in_arg_list.dp.cpp
+
+#include <cuda_runtime.h>
+#include <type_traits>
+#include <vector>
+
+namespace detail {
+template <typename Func, typename... Args>
+void check_cuda_error(const char *File, unsigned Line, Func &&Fn,
+                      Args &&...Arg) {
+  static_assert(std::is_same<decltype(Fn(Arg...)), cudaError_t>::value,
+                "Fn must return cudaError_t");
+  decltype(Fn(Arg...)) Ret = Fn(std::forward<Args>(Arg)...);
+  if (Ret != cudaSuccess) {
+    abort();
+  }
+}
+} // namespace detail
+
+#define AS_LAMBDA(func)                                                        \
+  [&](auto &&...args) -> decltype(func(                                        \
+                          std::forward<decltype(args)>(args)...)) {            \
+    return func(std::forward<decltype(args)>(args)...);                        \
+  }
+
+#define CHECK_CUDA_RET(FN, ...)                                                \
+  ::detail::check_cuda_error(__FILE__, __LINE__, AS_LAMBDA(FN), __VA_ARGS__)
+
+int *foo(size_t N, int Low, int High) {
+  int *Buffer = nullptr;
+  std::vector<int> Vec;
+
+  // 1. Crash in `clang::dpct::getSizeForMalloc`
+  // CHECK: CHECK_CUDA_RET(cudaMalloc<int>, &Buffer, sizeof(int) * N);
+  CHECK_CUDA_RET(cudaMalloc<int>, &Buffer, sizeof(int) * N);
+
+  // 2. Crash in `clang::dpct::MemoryMigrationRule::memcpyMigration`
+  // CHECK: CHECK_CUDA_RET(cudaMemcpy, Buffer, Vec.data(), Vec.size() * sizeof(int), dpct::host_to_device);
+  CHECK_CUDA_RET(cudaMemcpy, Buffer, Vec.data(), Vec.size() * sizeof(int), cudaMemcpyHostToDevice);
+  return Buffer;
+}