Skip to content

Commit ccedd1a

Browse files
authored
Misc. formatting fixes. (#137)
- Update the helper script to better align doxygen comments. - Use consistent language when referring to the pNext member of structures. - Reduce script warnings by adjusting the language used to refer to struct members. - Fix docs generation script to correctly handle etor errors. - Remove (comment out) deprecated/unused Doxygen flags Signed-off-by: Will Damon <[email protected]>
1 parent 26d7555 commit ccedd1a

39 files changed

+169
-155
lines changed

scripts/Doxyfile

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ OUTPUT_LANGUAGE = English
9999
# Possible values are: None, LTR, RTL and Context.
100100
# The default value is: None.
101101

102-
OUTPUT_TEXT_DIRECTION = None
102+
# OUTPUT_TEXT_DIRECTION = None
103103

104104
# If the BRIEF_MEMBER_DESC tag is set to YES, doxygen will include brief member
105105
# descriptions after the members that are listed in the file and class
@@ -1054,15 +1054,15 @@ VERBATIM_HEADERS = NO
10541054
# generated with the -Duse_libclang=ON option for CMake.
10551055
# The default value is: NO.
10561056

1057-
CLANG_ASSISTED_PARSING = NO
1057+
# CLANG_ASSISTED_PARSING = NO
10581058

10591059
# If clang assisted parsing is enabled you can provide the compiler with command
10601060
# line options that you would normally use when invoking the compiler. Note that
10611061
# the include paths will already be set by doxygen for the files and directories
10621062
# specified with INPUT and INCLUDE_PATH.
10631063
# This tag requires that the tag CLANG_ASSISTED_PARSING is set to YES.
10641064

1065-
CLANG_OPTIONS =
1065+
# CLANG_OPTIONS =
10661066

10671067
# If clang assisted parsing is enabled you can provide the clang parser with the
10681068
# path to the compilation database (see:
@@ -1072,7 +1072,7 @@ CLANG_OPTIONS =
10721072
# Note: The availability of this option depends on whether or not doxygen was
10731073
# generated with the -Duse_libclang=ON option for CMake.
10741074

1075-
CLANG_DATABASE_PATH =
1075+
# CLANG_DATABASE_PATH =
10761076

10771077
#---------------------------------------------------------------------------
10781078
# Configuration options related to the alphabetical class index
@@ -1090,7 +1090,7 @@ ALPHABETICAL_INDEX = YES
10901090
# Minimum value: 1, maximum value: 20, default value: 5.
10911091
# This tag requires that the tag ALPHABETICAL_INDEX is set to YES.
10921092

1093-
COLS_IN_ALPHA_INDEX = 5
1093+
# COLS_IN_ALPHA_INDEX = 5
10941094

10951095
# In case all classes in a project start with a common prefix, all classes will
10961096
# be put under the same header in the alphabetical index. The IGNORE_PREFIX tag
@@ -1518,7 +1518,7 @@ FORMULA_FONTSIZE = 10
15181518
# The default value is: YES.
15191519
# This tag requires that the tag GENERATE_HTML is set to YES.
15201520

1521-
FORMULA_TRANSPARENT = YES
1521+
# FORMULA_TRANSPARENT = YES
15221522

15231523
# Enable the USE_MATHJAX option to render LaTeX formulas using MathJax (see
15241524
# https://www.mathjax.org) which uses client side Javascript for the rendering
@@ -1838,7 +1838,7 @@ LATEX_HIDE_INDICES = NO
18381838
# The default value is: NO.
18391839
# This tag requires that the tag GENERATE_LATEX is set to YES.
18401840

1841-
LATEX_SOURCE_CODE = NO
1841+
# LATEX_SOURCE_CODE = NO
18421842

18431843
# The LATEX_BIB_STYLE tag can be used to specify the style to use for the
18441844
# bibliography, e.g. plainnat, or ieeetr. See
@@ -1928,7 +1928,7 @@ RTF_EXTENSIONS_FILE =
19281928
# The default value is: NO.
19291929
# This tag requires that the tag GENERATE_RTF is set to YES.
19301930

1931-
RTF_SOURCE_CODE = NO
1931+
# RTF_SOURCE_CODE = NO
19321932

19331933
#---------------------------------------------------------------------------
19341934
# Configuration options related to the man page output
@@ -2033,7 +2033,7 @@ DOCBOOK_OUTPUT = docbook
20332033
# The default value is: NO.
20342034
# This tag requires that the tag GENERATE_DOCBOOK is set to YES.
20352035

2036-
DOCBOOK_PROGRAMLISTING = NO
2036+
# DOCBOOK_PROGRAMLISTING = NO
20372037

20382038
#---------------------------------------------------------------------------
20392039
# Configuration options for the AutoGen Definitions output
@@ -2220,7 +2220,7 @@ EXTERNAL_PAGES = YES
22202220
# powerful graphs.
22212221
# The default value is: YES.
22222222

2223-
CLASS_DIAGRAMS = YES
2223+
# CLASS_DIAGRAMS = YES
22242224

22252225
# You can include diagrams made with dia in doxygen documentation. Doxygen will
22262226
# then run dia to produce the diagram and insert it in the documentation. The
@@ -2262,14 +2262,14 @@ DOT_NUM_THREADS = 0
22622262
# The default value is: Helvetica.
22632263
# This tag requires that the tag HAVE_DOT is set to YES.
22642264

2265-
DOT_FONTNAME = Helvetica
2265+
# DOT_FONTNAME = Helvetica
22662266

22672267
# The DOT_FONTSIZE tag can be used to set the size (in points) of the font of
22682268
# dot graphs.
22692269
# Minimum value: 4, maximum value: 24, default value: 10.
22702270
# This tag requires that the tag HAVE_DOT is set to YES.
22712271

2272-
DOT_FONTSIZE = 10
2272+
# DOT_FONTSIZE = 10
22732273

22742274
# By default doxygen will tell dot to use the default font as specified with
22752275
# DOT_FONTNAME. If you specify a different font using DOT_FONTNAME you can set
@@ -2493,7 +2493,7 @@ MAX_DOT_GRAPH_DEPTH = 0
24932493
# The default value is: NO.
24942494
# This tag requires that the tag HAVE_DOT is set to YES.
24952495

2496-
DOT_TRANSPARENT = NO
2496+
# DOT_TRANSPARENT = NO
24972497

24982498
# Set the DOT_MULTI_TARGETS tag to YES to allow dot to generate multiple output
24992499
# files in one run (i.e. multiple -o and -T options on the command line). This

scripts/core/EUCount.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,5 +36,5 @@ members:
3636
name: numTotalEUs
3737
desc: "[out] Total number of EUs available"
3838
details:
39-
- "This structure may be returned from $xDeviceGetProperties via `pNext` member of $x_device_properties_t"
39+
- "This structure may be returned from $xDeviceGetProperties via the `pNext` member of $x_device_properties_t."
4040
- "Used for determining the total number of EUs available on device."

scripts/core/cacheReservation.yml

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,27 @@ class: $xDevice
3232
name: $x_cache_ext_region_t
3333
etors:
3434
- name: $X_CACHE_REGION_DEFAULT
35-
desc: "utilize driver default scheme"
35+
desc:
36+
"1.6": "utilize driver default scheme"
37+
"1.7": "[DEPRECATED] utilize driver default scheme. Use $X_CACHE_EXT_REGION_DEFAULT."
3638
- name: $X_CACHE_RESERVE_REGION
37-
desc: "Utilize reserver region"
39+
desc:
40+
"1.6": "utilize reserved region"
41+
"1.7": "[DEPRECATED] utilize reserved region. Use $X_CACHE_EXT_REGION_RESERVED."
3842
- name: $X_CACHE_NON_RESERVED_REGION
39-
desc: "Utilize non-reserverd region"
43+
desc:
44+
"1.6": "utilize non-reserverd region"
45+
"1.7": "[DEPRECATED] utilize non-reserverd region. Use $X_CACHE_EXT_REGION_NON_RESERVED."
46+
- name: DEFAULT
47+
desc: "utilize driver default scheme"
48+
version: "1.7"
49+
value: "0"
50+
- name: RESERVED
51+
desc: "utilize reserved region"
52+
version: "1.7"
53+
- name: NON_RESERVED
54+
desc: "utilize non-reserverd region"
55+
version: "1.7"
4056
--- #--------------------------------------------------------------------------
4157
type: struct
4258
desc: "CacheReservation structure"
@@ -49,7 +65,7 @@ members:
4965
name: maxCacheReservationSize
5066
desc: "[out] max cache reservation size"
5167
details:
52-
- "This structure must be passed to $xDeviceGetCacheProperties via `pNext` member of $x_device_cache_properties_t"
68+
- "This structure must be passed to $xDeviceGetCacheProperties via the `pNext` member of $x_device_cache_properties_t"
5369
- "Used for determining the max cache reservation allowed on device. Size of zero means no reservation available."
5470
--- #--------------------------------------------------------------------------
5571
type: function

scripts/core/cmdlist.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,8 @@ class: $xCommandList
153153
name: AppendWriteGlobalTimestamp
154154
details:
155155
- "The application must ensure the events are accessible by the device on which the command list was created."
156-
- "The timestamp frequency can be queried from $x_device_properties_t.timerResolution."
157-
- "The number of valid bits in the timestamp value can be queried from $x_device_properties_t.timestampValidBits."
156+
- "The timestamp frequency can be queried from the `timerResolution` member of $x_device_properties_t."
157+
- "The number of valid bits in the timestamp value can be queried from the `timestampValidBits` member of $x_device_properties_t."
158158
- "The application must ensure the memory pointed to by dstptr is accessible by the device on which the command list was created."
159159
- "The application must ensure the command list and events were created, and the memory was allocated, on the same context."
160160
- "The application must **not** call this function from simultaneous threads with the same command list handle."
@@ -201,7 +201,7 @@ params:
201201
desc: |
202202
[in] if non-zero, then indicates the maximum time (in nanoseconds) to yield before returning $X_RESULT_SUCCESS or $X_RESULT_NOT_READY;
203203
if zero, then immediately returns the status of the immediate command list;
204-
if UINT64_MAX, then function will not return until complete or device is lost.
204+
if `UINT64_MAX`, then function will not return until complete or device is lost.
205205
Due to external dependencies, timeout may be rounded to the closest value allowed by the accuracy of those dependencies.
206206
returns:
207207
- $X_RESULT_NOT_READY:

scripts/core/cmdqueue.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ params:
181181
desc: |
182182
[in] if non-zero, then indicates the maximum time (in nanoseconds) to yield before returning $X_RESULT_SUCCESS or $X_RESULT_NOT_READY;
183183
if zero, then immediately returns the status of the command queue;
184-
if UINT64_MAX, then function will not return until complete or device is lost.
184+
if `UINT64_MAX`, then function will not return until complete or device is lost.
185185
Due to external dependencies, timeout may be rounded to the closest value allowed by the accuracy of those dependencies.
186186
returns:
187187
- $X_RESULT_NOT_READY:

scripts/core/copy.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ details:
6060
- "The application must ensure the memory pointed to by dstptr is accessible by the device on which the command list was created."
6161
- "The implementation must not access the memory pointed to by dstptr as it is free to be modified by either the Host or device up until execution."
6262
- "The value to initialize memory to is described by the pattern and the pattern size."
63-
- "The pattern size must be a power-of-two and less than or equal to $x_command_queue_group_properties_t.maxMemoryFillPatternSize."
63+
- "The pattern size must be a power-of-two and less than or equal to the `maxMemoryFillPatternSize` member of $x_command_queue_group_properties_t."
6464
- "The application must ensure the events are accessible by the device on which the command list was created."
6565
- "The application must ensure the command list and events were created, and the memory was allocated, on the same context."
6666
- "The application must **not** call this function from simultaneous threads with the same command list handle."
@@ -150,7 +150,7 @@ params:
150150
desc: "[in] destination pitch in bytes"
151151
- type: "uint32_t"
152152
name: dstSlicePitch
153-
desc: "[in] destination slice pitch in bytes. This is required for 3D region copies where $x_copy_region_t.depth is not 0, otherwise it's ignored."
153+
desc: "[in] destination slice pitch in bytes. This is required for 3D region copies where the `depth` member of $x_copy_region_t is not 0, otherwise it's ignored."
154154
- type: "const void*"
155155
name: srcptr
156156
desc: "[in] pointer to source memory to copy from"
@@ -162,7 +162,7 @@ params:
162162
desc: "[in] source pitch in bytes"
163163
- type: "uint32_t"
164164
name: srcSlicePitch
165-
desc: "[in] source slice pitch in bytes. This is required for 3D region copies where $x_copy_region_t.depth is not 0, otherwise it's ignored."
165+
desc: "[in] source slice pitch in bytes. This is required for 3D region copies where the `depth` member of $x_copy_region_t is not 0, otherwise it's ignored."
166166
- type: $x_event_handle_t
167167
name: hSignalEvent
168168
desc: "[in][optional] handle of the event to signal on completion"

scripts/core/device.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -192,22 +192,22 @@ members:
192192
name: slice
193193
desc: |
194194
[in,out] the slice number.
195-
Must be UINT32_MAX (all) or less than $x_device_properties_t.numSlices.
195+
Must be `UINT32_MAX` (all) or less than the `numSlices` member of $x_device_properties_t.
196196
- type: "uint32_t"
197197
name: subslice
198198
desc: |
199199
[in,out] the sub-slice number within its slice.
200-
Must be UINT32_MAX (all) or less than $x_device_properties_t.numSubslicesPerSlice.
200+
Must be `UINT32_MAX` (all) or less than the `numSubslicesPerSlice` member of $x_device_properties_t.
201201
- type: "uint32_t"
202202
name: eu
203203
desc: |
204204
[in,out] the EU number within its sub-slice.
205-
Must be UINT32_MAX (all) or less than $x_device_properties_t.numEUsPerSubslice.
205+
Must be `UINT32_MAX` (all) or less than the `numEUsPerSubslice` member of $x_device_properties_t.
206206
- type: "uint32_t"
207207
name: thread
208208
desc: |
209209
[in,out] the thread number within its EU.
210-
Must be UINT32_MAX (all) or less than $x_device_properties_t.numThreadsPerEU.
210+
Must be `UINT32_MAX` (all) or less than the `numThreadsPerEU` member of $x_device_properties_t.
211211
--- #--------------------------------------------------------------------------
212212
type: function
213213
desc: "Retrieves properties of the device."

scripts/core/deviceLUID.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,4 +63,4 @@ members:
6363
Otherwise, the returned node mask must be 1.
6464
6565
details:
66-
- "This structure may be returned from $xDeviceGetProperties, via `pNext` member of $x_device_properties_t."
66+
- "This structure may be returned from $xDeviceGetProperties, via the `pNext` member of $x_device_properties_t."

scripts/core/deviceipversion.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,5 +40,5 @@ members:
4040
version than older devices.
4141
4242
details:
43-
- "This structure may be returned from $xDeviceGetProperties via `pNext` member of $x_device_properties_t"
43+
- "This structure may be returned from $xDeviceGetProperties via the `pNext` member of $x_device_properties_t"
4444

scripts/core/event.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ params:
331331
desc: |
332332
[in] if non-zero, then indicates the maximum time (in nanoseconds) to yield before returning $X_RESULT_SUCCESS or $X_RESULT_NOT_READY;
333333
if zero, then operates exactly like $xEventQueryStatus;
334-
if UINT64_MAX, then function will not return until complete or device is lost.
334+
if `UINT64_MAX`, then function will not return until complete or device is lost.
335335
Due to external dependencies, timeout may be rounded to the closest value allowed by the accuracy of those dependencies.
336336
returns:
337337
- $X_RESULT_ERROR_INVALID_SYNCHRONIZATION_OBJECT
@@ -399,8 +399,8 @@ desc: "Kernel timestamp clock data"
399399
class: $xEvent
400400
name: $x_kernel_timestamp_data_t
401401
details:
402-
- "The timestamp frequency can be queried from $x_device_properties_t.timerResolution."
403-
- "The number of valid bits in the timestamp value can be queried from $x_device_properties_t.kernelTimestampValidBits."
402+
- "The timestamp frequency can be queried from the `timerResolution` member of $x_device_properties_t."
403+
- "The number of valid bits in the timestamp value can be queried from the `kernelTimestampValidBits` member of $x_device_properties_t."
404404
members:
405405
- type: uint64_t
406406
name: kernelStart

0 commit comments

Comments
 (0)