Skip to content

Commit 09f19de

Browse files
authored
test: fix ip sampling no overflow test (#316)
Related-To: NEO-16556 Signed-off-by: shubham kumar <[email protected]>
1 parent 6cd2fde commit 09f19de

File tree

3 files changed

+17
-6
lines changed

3 files changed

+17
-6
lines changed

conformance_tests/tools/metrics/src/test_metric.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1597,7 +1597,7 @@ LZT_TEST_F(
15971597
GivenValidTypeIpMetricGroupWhenTimerBasedStreamerIsCreatedWithNoOverflowThenValidateStallSampleData) {
15981598
metric_run_ip_sampling_with_validation(false, devices, notifyEveryNReports,
15991599
samplingPeriod,
1600-
to_u32(TimeForNReportsComplete));
1600+
to_u32(TimeForNReportsComplete), 4096);
16011601
}
16021602

16031603
LZT_TEST_F(

conformance_tests/tools/metrics/src/test_metric_utils.cpp

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ void metric_validate_stall_sampling_data(
6969
std::vector<zet_typed_value_t> &totalMetricValues,
7070
std::vector<uint32_t> &metricValueSets) {
7171

72+
uint32_t ipOffset = UINT32_MAX;
7273
uint32_t activeOffset = UINT32_MAX;
7374
uint32_t controlStallOffset = UINT32_MAX;
7475
uint32_t pipeStallOffset = UINT32_MAX;
@@ -81,6 +82,10 @@ void metric_validate_stall_sampling_data(
8182

8283
for (uint32_t i = 0; i < to_u32(metricProperties.size()); i++) {
8384

85+
if (strcmp("IP", metricProperties[i].name) == 0) {
86+
ipOffset = i;
87+
continue;
88+
}
8489
if (strcmp("Active", metricProperties[i].name) == 0) {
8590
activeOffset = i;
8691
continue;
@@ -119,6 +124,7 @@ void metric_validate_stall_sampling_data(
119124
}
120125
}
121126

127+
uint64_t IpAddress = 0;
122128
uint64_t ActiveCount = 0;
123129
uint64_t ControlStallCount = 0;
124130
uint64_t PipeStallCount = 0;
@@ -167,6 +173,9 @@ void metric_validate_stall_sampling_data(
167173
};
168174
uint32_t metricPropsSize = to_u32(metricProperties.size());
169175

176+
IpAddress =
177+
getStallCount(report, metricPropsSize, ipOffset, metricSetStartIndex);
178+
170179
tmpStallCount = getStallCount(report, metricPropsSize, activeOffset,
171180
metricSetStartIndex);
172181
reportCompleteFlag |= (tmpStallCount != 0);
@@ -212,8 +221,10 @@ void metric_validate_stall_sampling_data(
212221
reportCompleteFlag |= (tmpStallCount != 0);
213222
OtherStallCount += tmpStallCount;
214223

215-
EXPECT_TRUE(reportCompleteFlag)
216-
<< "Report number " << report << " has zero for all stall counts";
224+
if (!reportCompleteFlag) {
225+
LOG_INFO << "Report number " << report << " with IP address "
226+
<< IpAddress << " has zero for all stall counts";
227+
}
217228
}
218229

219230
metricSetStartIndex += metricCountForDataIndex;
@@ -233,7 +244,7 @@ void metric_validate_stall_sampling_data(
233244
void metric_run_ip_sampling_with_validation(
234245
bool enableOverflow, const std::vector<ze_device_handle_t> &devices,
235246
uint32_t notifyEveryNReports, uint32_t samplingPeriod,
236-
uint32_t timeForNReportsComplete) {
247+
uint32_t timeForNReportsComplete, uint32_t dimensions = 8192) {
237248

238249
uint32_t numberOfFunctionCalls;
239250
if (enableOverflow) {
@@ -289,7 +300,7 @@ void metric_run_ip_sampling_with_validation(
289300
for (auto &fData : functionDataBuf) {
290301
fData.function = get_matrix_multiplication_kernel(
291302
device, &fData.tg, &fData.a_buffer, &fData.b_buffer,
292-
&fData.c_buffer, 8192);
303+
&fData.c_buffer, dimensions);
293304
zeCommandListAppendLaunchKernel(commandList, fData.function, &fData.tg,
294305
nullptr, 0, nullptr);
295306
}

conformance_tests/tools/metrics/src/test_metric_utils.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@ void metric_validate_stall_sampling_data(
2424
void metric_run_ip_sampling_with_validation(
2525
bool enableOverflow, const std::vector<ze_device_handle_t> &devices,
2626
uint32_t notifyEveryNReports, uint32_t samplingPeriod,
27-
uint32_t timeForNReportsComplete);
27+
uint32_t timeForNReportsComplete, uint32_t dimensions = 8192);
2828

2929
#endif // TEST_METRIC_UTILS_HPP

0 commit comments

Comments
 (0)