Skip to content

Commit 6f041c9

Browse files
authored
FPGA: Remove unused fno-finite-math flag (#2547)
The `finite-math` flag has been disabled by default from llvm (intel/llvm@c9c91f5). Therefore, the samples that used to set `fno-finite-math` have started generated a warning about the flag not been used. This PR removes the now unnecessary flag.
1 parent d5e57da commit 6f041c9

File tree

6 files changed

+6
-20
lines changed

6 files changed

+6
-20
lines changed

DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/cholesky/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ endif()
6666
# Prevent ignoring NaN values
6767
if(WIN32)
6868
set(EMULATOR_PLATFORM_FLAGS -fp:precise)
69-
else()
70-
set(EXTRA_COMPILE_FLAG -fno-finite-math-only)
7169
endif()
7270

7371
if(DEVICE_FLAG MATCHES "A10")
@@ -120,7 +118,7 @@ message(STATUS "FIXED_ITERATIONS=${FIXED_ITERATIONS}")
120118
set(USER_FPGA_FLAGS ${USER_FPGA_FLAGS};${SEED};${CLOCK_TARGET})
121119

122120
# Use cmake -DUSER_FLAGS=<flags> to set extra flags for general compilation.
123-
set(USER_FLAGS ${USER_FLAGS};${BSP_FLAG};-DFIXED_ITERATIONS=${FIXED_ITERATIONS};-DCOMPLEX=${COMPLEX};-DMATRIX_DIMENSION=${MATRIX_DIMENSION};-fbracket-depth=512;${EXTRA_COMPILE_FLAG})
121+
set(USER_FLAGS ${USER_FLAGS};${BSP_FLAG};-DFIXED_ITERATIONS=${FIXED_ITERATIONS};-DCOMPLEX=${COMPLEX};-DMATRIX_DIMENSION=${MATRIX_DIMENSION};-fbracket-depth=512)
124122

125123
# Use cmake -DUSER_INCLUDE_PATHS=<paths> to set extra paths for general
126124
# compilation.

DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/cholesky_inversion/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ endif()
6666
# Prevent ignoring NaN values
6767
if(WIN32)
6868
set(EMULATOR_PLATFORM_FLAGS -fp:precise)
69-
else()
70-
set(EXTRA_COMPILE_FLAG -fno-finite-math-only)
7169
endif()
7270

7371
if(DEVICE_FLAG MATCHES "A10")
@@ -128,7 +126,7 @@ message(STATUS "FIXED_ITERATIONS_INVERSION=${FIXED_ITERATIONS_INVERSION}")
128126
set(USER_FPGA_FLAGS ${USER_FPGA_FLAGS};${SEED};${CLOCK_TARGET})
129127

130128
# Use cmake -DUSER_FLAGS=<flags> to set extra flags for general compilation.
131-
set(USER_FLAGS ${USER_FLAGS};${BSP_FLAG};-DFIXED_ITERATIONS_DECOMPOSITION=${FIXED_ITERATIONS_DECOMPOSITION};-DFIXED_ITERATIONS_INVERSION=${FIXED_ITERATIONS_INVERSION};-DCOMPLEX=${COMPLEX};-DMATRIX_DIMENSION=${MATRIX_DIMENSION};-fbracket-depth=512;${EXTRA_COMPILE_FLAG})
129+
set(USER_FLAGS ${USER_FLAGS};${BSP_FLAG};-DFIXED_ITERATIONS_DECOMPOSITION=${FIXED_ITERATIONS_DECOMPOSITION};-DFIXED_ITERATIONS_INVERSION=${FIXED_ITERATIONS_INVERSION};-DCOMPLEX=${COMPLEX};-DMATRIX_DIMENSION=${MATRIX_DIMENSION};-fbracket-depth=512)
132130

133131
# Use cmake -DUSER_INCLUDE_PATHS=<paths> to set extra paths for general
134132
# compilation.

DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/matmul/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,6 @@ endif()
6868
# Prevent ignoring NaN values
6969
if(WIN32)
7070
set(EMULATOR_PLATFORM_FLAGS -fp:precise)
71-
else()
72-
set(EXTRA_COMPILE_FLAG -fno-finite-math-only)
7371
endif()
7472

7573
# Set design parameters according to the selected board
@@ -136,7 +134,7 @@ message(STATUS "SEED=${SEED}")
136134
set(USER_FPGA_FLAGS ${USER_FPGA_FLAGS};${SEED};-Xsclock=${CLOCK_TARGET})
137135

138136
# Use cmake -DUSER_FLAGS=<flags> to set extra flags for general compilation.
139-
set(USER_FLAGS ${USER_FLAGS};${EXTRA_COMPILE_FLAG};-DROWS_A=${ROWS_A};-DCOMMON=${COMMON};-DCOLS_B=${COLS_B};-DTILE_A=${TILE_A};-DTILE_B=${TILE_B};${BSP_FLAG})
137+
set(USER_FLAGS ${USER_FLAGS};-DROWS_A=${ROWS_A};-DCOMMON=${COMMON};-DCOLS_B=${COLS_B};-DTILE_A=${TILE_A};-DTILE_B=${TILE_B};${BSP_FLAG})
140138

141139
# Use cmake -DUSER_INCLUDE_PATHS=<paths> to set extra paths for general
142140
# compilation.

DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/pca/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,6 @@ if(WIN32)
7070
set(PRECISE_FLAG "-fp:precise")
7171
else()
7272
set(PRECISE_FLAG "-fp-model=precise")
73-
# Prevent ignoring NaN values
74-
set(EXTRA_COMPILE_FLAG -fno-finite-math-only)
7573
endif()
7674

7775
set(BENCHMARK 1)
@@ -119,7 +117,7 @@ endif()
119117
set(USER_FPGA_FLAGS ${USER_FPGA_FLAGS})
120118

121119
# Use cmake -DUSER_FLAGS=<flags> to set extra flags for general compilation.
122-
set(USER_FLAGS ${USER_FLAGS};${PRECISE_FLAG};${EXTRA_COMPILE_FLAG};-fbracket-depth=512;-DFIXED_ITERATIONS=${FIXED_ITERATIONS};-DFEATURES_COUNT=${FEATURES_COUNT};-DSAMPLES_COUNT=${SAMPLES_COUNT};-DBENCHMARK=${BENCHMARK};${BSP_FLAG})
120+
set(USER_FLAGS ${USER_FLAGS};${PRECISE_FLAG};-fbracket-depth=512;-DFIXED_ITERATIONS=${FIXED_ITERATIONS};-DFEATURES_COUNT=${FEATURES_COUNT};-DSAMPLES_COUNT=${SAMPLES_COUNT};-DBENCHMARK=${BENCHMARK};${BSP_FLAG})
123121

124122
# Use cmake -DUSER_INCLUDE_PATHS=<paths> to set extra paths for general
125123
# compilation.

DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/qrd/CMakeLists.txt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,6 @@ endif()
6969
if(WIN32)
7070
set(EXTRA_EMULATOR_COMPILE_FLAGS "-fp:precise")
7171
set(STACK_FLAG "-F 12582912")
72-
else()
73-
# Prevent ignoring NaN values
74-
set(EXTRA_COMPILE_FLAG "-fno-finite-math-only")
7572
endif()
7673

7774
if(DEVICE_FLAG MATCHES "A10")
@@ -133,7 +130,7 @@ message(STATUS "SEED=${SEED}")
133130
set(USER_FPGA_FLAGS ${USER_FPGA_FLAGS};${CLOCK_TARGET})
134131

135132
# Use cmake -DUSER_FLAGS=<flags> to set extra flags for general compilation.
136-
set(USER_FLAGS ${USER_FLAGS};${EXTRA_COMPILE_FLAG};-fbracket-depth=512;${BSP_FLAG};-DFIXED_ITERATIONS=${FIXED_ITERATIONS} -DCOMPLEX=${COMPLEX};-DROWS_COMPONENT=${ROWS_COMPONENT};-DCOLS_COMPONENT=${COLS_COMPONENT})
133+
set(USER_FLAGS ${USER_FLAGS};-fbracket-depth=512;${BSP_FLAG};-DFIXED_ITERATIONS=${FIXED_ITERATIONS} -DCOMPLEX=${COMPLEX};-DROWS_COMPONENT=${ROWS_COMPONENT};-DCOLS_COMPONENT=${COLS_COMPONENT})
137134

138135
# Use cmake -DUSER_INCLUDE_PATHS=<paths> to set extra paths for general
139136
# compilation.

DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/qri/CMakeLists.txt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,6 @@ endif()
6868
# Platform specific flags
6969
if(WIN32)
7070
set(EXTRA_EMULATOR_COMPILE_FLAGS "-fp:precise")
71-
else()
72-
# Prevent ignoring NaN values
73-
set(EXTRA_COMPILE_FLAG "-fno-finite-math-only")
7471
endif()
7572

7673
if(DEVICE_FLAG MATCHES "A10")
@@ -140,7 +137,7 @@ message(STATUS "SEED=${SEED}")
140137
set(USER_FPGA_FLAGS ${USER_FPGA_FLAGS};-Xsclock=${CLOCK_TARGET})
141138

142139
# Use cmake -DUSER_FLAGS=<flags> to set extra flags for general compilation.
143-
set(USER_FLAGS ${USER_FLAGS};${EXTRA_COMPILE_FLAG};-fbracket-depth=512;${BSP_FLAG};-DFIXED_ITERATIONS_QRD=${FIXED_ITERATIONS_QRD};-DFIXED_ITERATIONS_QRI=${FIXED_ITERATIONS_QRI};-DCOMPLEX=${COMPLEX};-DROWS_COMPONENT=${ROWS_COMPONENT};-DCOLS_COMPONENT=${COLS_COMPONENT})
140+
set(USER_FLAGS ${USER_FLAGS};-fbracket-depth=512;${BSP_FLAG};-DFIXED_ITERATIONS_QRD=${FIXED_ITERATIONS_QRD};-DFIXED_ITERATIONS_QRI=${FIXED_ITERATIONS_QRI};-DCOMPLEX=${COMPLEX};-DROWS_COMPONENT=${ROWS_COMPONENT};-DCOLS_COMPONENT=${COLS_COMPONENT})
144141

145142
# Use cmake -DUSER_INCLUDE_PATHS=<paths> to set extra paths for general
146143
# compilation.

0 commit comments

Comments
 (0)