FPGA: Fix IS_BSP flow for pca and qri (#2501)

justin-rosner · web-flow · commit 7bb3748684a2 · 2024-09-27T15:46:45.000+02:00
This change addresses a bug in the full-system flow where a pointer was not being passed into MatrixReadPipeToDDR.
diff --git a/DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/pca/src/memory_transfers.hpp b/DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/pca/src/memory_transfers.hpp
@@ -72,7 +72,7 @@ template <typename TT,            // Datatype of the elements of the matrix
           >
 void MatrixReadPipeToDDR(
 #if defined (IS_BSP)
-    TT matrix_ptr,  // Output matrix pointer
+    TT* matrix_ptr,  // Output matrix pointer
 # else
     annotated_ptr<TT, decltype(properties{buffer_location<BL0>,
                                           dwidth<512>})> matrix_ptr,
diff --git a/DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/qri/src/memory_transfers.hpp b/DirectProgramming/C++SYCL_FPGA/ReferenceDesigns/qri/src/memory_transfers.hpp
@@ -126,7 +126,7 @@ template <typename TT,           // Datatype of the elements of the matrix
           >
 void MatrixReadPipeToDDR(
 #if defined (IS_BSP)
-    TT matrix_ptr,  // Output matrix pointer
+    TT* matrix_ptr,  // Output matrix pointer
 # else
     annotated_ptr<TT, decltype(properties{buffer_location<BL0>,
                                           dwidth<512>})> matrix_ptr,

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ template <typename TT, // Datatype of the elements of the matrix`
`72`	`72`	`>`
`73`	`73`	`void MatrixReadPipeToDDR(`
`74`	`74`	`#if defined (IS_BSP)`
`75`		`- TT matrix_ptr, // Output matrix pointer`
	`75`	`+ TT* matrix_ptr, // Output matrix pointer`
`76`	`76`	`# else`
`77`	`77`	`annotated_ptr<TT, decltype(properties{buffer_location<BL0>,`
`78`	`78`	`dwidth<512>})> matrix_ptr,`
Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ template <typename TT, // Datatype of the elements of the matrix`
`126`	`126`	`>`
`127`	`127`	`void MatrixReadPipeToDDR(`
`128`	`128`	`#if defined (IS_BSP)`
`129`		`- TT matrix_ptr, // Output matrix pointer`
	`129`	`+ TT* matrix_ptr, // Output matrix pointer`
`130`	`130`	`# else`
`131`	`131`	`annotated_ptr<TT, decltype(properties{buffer_location<BL0>,`
`132`	`132`	`dwidth<512>})> matrix_ptr,`