Use std::vector<char> instead of std::unique_ptr<char[]>

Use std::vector<char> instead of std::unique_ptr<char[]>
because we do not need to use memset(0) in this case.

Signed-off-by: Lukasz Dorau <[email protected]>

Author: ldorau

test/disjointCoarseMallocPool.cpp

@@ -395,11 +395,10 @@ TEST_P(CoarseWithMemoryStrategyTest, disjointCoarseMMapPool_random) {
 
     const size_t init_buffer_size = 200 * MB;
 
-    // Preallocate some memory
-    std::unique_ptr<char[]> buffer(new char[init_buffer_size]);
-    void *buf = buffer.get();
+    // preallocate some memory and initialize the vector with zeros
+    std::vector<char> buffer(init_buffer_size, 0);
+    void *buf = buffer.data();
     ASSERT_NE(buf, nullptr);
-    memset(buf, 0, init_buffer_size);
 
     const unsigned char alloc_check_val = 11;
 

test/provider_coarse.cpp

@@ -86,11 +86,10 @@ TEST_F(test, disjointCoarseMallocPool_name_no_upstream) {
 
     const size_t init_buffer_size = 20 * MB;
 
-    // Preallocate some memory
-    std::unique_ptr<char[]> buffer(new char[init_buffer_size]);
-    void *buf = buffer.get();
+    // preallocate some memory and initialize the vector with zeros
+    std::vector<char> buffer(init_buffer_size, 0);
+    void *buf = buffer.data();
     ASSERT_NE(buf, nullptr);
-    memset(buf, 0, init_buffer_size);
 
     coarse_memory_provider_params_t coarse_memory_provider_params;
     // make sure there are no undefined members - prevent a UB
@@ -160,11 +159,10 @@ TEST_P(CoarseWithMemoryStrategyTest, disjointCoarseMallocPool_wrong_params_1) {
 
     const size_t init_buffer_size = 20 * MB;
 
-    // Preallocate some memory
-    std::unique_ptr<char[]> buffer(new char[init_buffer_size]);
-    void *buf = buffer.get();
+    // preallocate some memory and initialize the vector with zeros
+    std::vector<char> buffer(init_buffer_size, 0);
+    void *buf = buffer.data();
     ASSERT_NE(buf, nullptr);
-    memset(buf, 0, init_buffer_size);
 
     coarse_memory_provider_params_t coarse_memory_provider_params;
     // make sure there are no undefined members - prevent a UB
@@ -224,11 +222,10 @@ TEST_P(CoarseWithMemoryStrategyTest, disjointCoarseMallocPool_wrong_params_3) {
 
     const size_t init_buffer_size = 20 * MB;
 
-    // Preallocate some memory
-    std::unique_ptr<char[]> buffer(new char[init_buffer_size]);
-    void *buf = buffer.get();
+    // preallocate some memory and initialize the vector with zeros
+    std::vector<char> buffer(init_buffer_size, 0);
+    void *buf = buffer.data();
     ASSERT_NE(buf, nullptr);
-    memset(buf, 0, init_buffer_size);
 
     coarse_memory_provider_params_t coarse_memory_provider_params;
     // make sure there are no undefined members - prevent a UB
@@ -285,11 +282,10 @@ TEST_P(CoarseWithMemoryStrategyTest, disjointCoarseMallocPool_wrong_params_5) {
 
     const size_t init_buffer_size = 20 * MB;
 
-    // Preallocate some memory
-    std::unique_ptr<char[]> buffer(new char[init_buffer_size]);
-    void *buf = buffer.get();
+    // preallocate some memory and initialize the vector with zeros
+    std::vector<char> buffer(init_buffer_size, 0);
+    void *buf = buffer.data();
     ASSERT_NE(buf, nullptr);
-    memset(buf, 0, init_buffer_size);
 
     coarse_memory_provider_params_t coarse_memory_provider_params;
     // make sure there are no undefined members - prevent a UB
@@ -524,11 +520,10 @@ TEST_P(CoarseWithMemoryStrategyTest,
 
     const size_t init_buffer_size = 20 * MB;
 
-    // Preallocate some memory
-    std::unique_ptr<char[]> buffer(new char[init_buffer_size]);
-    void *buf = buffer.get();
+    // preallocate some memory and initialize the vector with zeros
+    std::vector<char> buffer(init_buffer_size, 0);
+    void *buf = buffer.data();
     ASSERT_NE(buf, nullptr);
-    memset(buf, 0, init_buffer_size);
 
     coarse_memory_provider_params_t coarse_memory_provider_params;
     // make sure there are no undefined members - prevent a UB