fix umfDisjointPoolParamsDestroy

Author: bratpiorka

src/base_alloc/base_alloc_global.c

@@ -28,8 +28,7 @@ static bool ba_is_destroyed = false;
 #define ALLOC_METADATA_SIZE (sizeof(size_t))
 
 // allocation classes need to be consecutive powers of 2
-#define ALLOCATION_CLASSES                                                     \
-    { 16, 32, 64, 128, 256 }
+#define ALLOCATION_CLASSES {16, 32, 64, 128, 256}
 #define NUM_ALLOCATION_CLASSES 5
 
 struct base_alloc_t {
@@ -55,7 +54,7 @@ void umf_ba_destroy_global(void) {
     memcpy(&ba_is_initialized, &set_once, sizeof(ba_is_initialized));
 }
 
-bool umf_ba_global_is_destroyed() { return ba_is_destroyed; }
+bool umf_ba_global_is_destroyed(void) { return ba_is_destroyed; }
 
 static void umf_ba_create_global(void) {
     for (int i = 0; i < NUM_ALLOCATION_CLASSES; i++) {

src/base_alloc/base_alloc_global.h

@@ -19,7 +19,7 @@ extern "C" {
 void *umf_ba_global_alloc(size_t size);
 void umf_ba_global_free(void *ptr);
 void umf_ba_destroy_global(void);
-bool umf_ba_global_is_destroyed();
+bool umf_ba_global_is_destroyed(void);
 size_t umf_ba_global_malloc_usable_size(void *ptr);
 void *umf_ba_global_aligned_alloc(size_t size, size_t alignment);
 

src/pool/pool_disjoint.c

@@ -1098,7 +1098,8 @@ umfDisjointPoolParamsCreate(umf_disjoint_pool_params_handle_t *hParams) {
 
 umf_result_t
 umfDisjointPoolParamsDestroy(umf_disjoint_pool_params_handle_t hParams) {
-    if (hParams) {
+    // NOTE: dereferencing hParams when BA is already destroyed leads to crash
+    if (hParams && !umf_ba_global_is_destroyed()) {
         umf_ba_global_free(hParams->name);
         umf_ba_global_free(hParams);
     }