Enable -Werror in developer build

Author: staniewzki

cmake/helpers.cmake

@@ -244,8 +244,9 @@ function(add_umf_target_compile_options name)
             target_compile_definitions(${name} PRIVATE -D_FORTIFY_SOURCE=2)
         endif()
         if(UMF_DEVELOPER_MODE)
-            target_compile_options(${name} PRIVATE -fno-omit-frame-pointer
-                                                   -fstack-protector-strong)
+            target_compile_options(
+                ${name} PRIVATE -fno-omit-frame-pointer
+                                -fstack-protector-strong -Werror)
         endif()
         if(UMF_USE_COVERAGE)
             if(NOT CMAKE_BUILD_TYPE STREQUAL "Debug")
@@ -279,6 +280,9 @@ function(add_umf_target_compile_options name)
                     # disable 4200 warning: nonstandard extension used:
                     # zero-sized array in struct/union
                     /wd4200)
+        if(UMF_DEVELOPER_MODE)
+            target_compile_options(${name} PRIVATE /WX)
+        endif()
         if(${CMAKE_C_COMPILER_ID} MATCHES "MSVC")
             target_compile_options(
                 ${name}

src/ipc_cache.c

@@ -96,6 +96,10 @@ static size_t getGlobalLruListSize(lru_list_t lru_list) {
     return size;
 }
 
+// Added to silence unused function warning.
+// TODO: remove this when the function above is used somewhere
+void useGetGlobalLruListSize(void) { (void *)&getGlobalLruListSize; }
+
 void umfIpcCacheGlobalTearDown(void) {
     ipc_mapped_handle_cache_global_t *cache_global = IPC_MAPPED_CACHE_GLOBAL;
     IPC_MAPPED_CACHE_GLOBAL = NULL;

src/provider/provider_devdax_memory.c

@@ -474,7 +474,7 @@ static umf_result_t devdax_open_ipc_handle(void *provider,
     LOG_DEBUG("devdax mapped (path: %s, size: %zu, protection: %i, fd: %i, "
               "offset: %zu) to address %p",
               devdax_ipc_data->path, length_aligned,
-              devdax_ipc_data->protection, fd, offset_aligned, addr);
+              devdax_ipc_data->protection, fd, offset_aligned, (void *)addr);
 
     *ptr = addr;
 

src/provider/provider_file_memory.c

@@ -697,7 +697,8 @@ static umf_result_t file_open_ipc_handle(void *provider, void *providerIpcData,
     LOG_DEBUG("file mapped (path: %s, size: %zu, protection: %i, fd: %i, "
               "offset: %zu) at address %p",
               file_ipc_data->path, file_ipc_data->size,
-              file_ipc_data->protection, fd, file_ipc_data->offset_fd, addr);
+              file_ipc_data->protection, fd, file_ipc_data->offset_fd,
+              (void *)addr);
 
     *ptr = addr;
 

test/CMakeLists.txt

@@ -75,8 +75,11 @@ function(build_umf_test)
         # tests retrieve arguments using 'GetParam()', which applies a 'const'
         # qualifier often discarded in the test scenarios.
         target_compile_options(${TEST_TARGET_NAME} PRIVATE -Wno-cast-qual)
-    endif()
 
+        if(UMF_DEVELOPER_MODE)
+            target_compile_options(${TEST_TARGET_NAME} PRIVATE -Werror)
+        endif()
+    endif()
     target_link_directories(${TEST_TARGET_NAME} PRIVATE ${LIB_DIRS})
 
     target_include_directories(

test/ipc_os_prov_proxy.c

@@ -106,9 +106,9 @@ int main(int argc, char *argv[]) {
     }
 
     fprintf(stderr, "Allocated memory - %zu\n", size);
-    size_t val = 144;
-    size_t expected_val = val / 2;
-    *(size_t *)ptr = val;
+    unsigned long long val = 144;
+    unsigned long long expected_val = val / 2;
+    *(unsigned long long *)ptr = val;
 
     // get IPC handle of the allocation
     umf_ipc_handle_t ipc_handle = NULL;

test/poolFixtures.hpp

@@ -70,6 +70,11 @@ struct umfPoolTest : umf_test::test,
 
         auto [pool_ops, pool_params, provider_ops, provider_params,
               coarse_params] = this->GetParam();
+        (void)pool_ops;
+        (void)pool_params;
+        (void)provider_params;
+        (void)coarse_params;
+
         if (provider_ops == umfDevDaxMemoryProviderOps()) {
             char *path = getenv("UMF_TESTS_DEVDAX_PATH");
             if (path == nullptr || path[0] == 0) {