Skip to content

Commit 3032c20

Browse files
[CI] Silence the warning for unused CMake option under Windows
Fixes: #123
1 parent 86b8d7c commit 3032c20

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

.github/workflows/codeql.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ jobs:
2727
- os: ubuntu-latest
2828
nproc: $(nproc)
2929
pool_scalable: 'ON'
30+
# Windows doesn't recognize 'CMAKE_BUILD_TYPE', it uses '--config' param in build command
31+
extra_build_option: ['-DCMAKE_BUILD_TYPE=Release']
3032
- os: windows-latest
3133
nproc: $Env:NUMBER_OF_PROCESSORS
3234
pool_scalable: 'OFF'
@@ -54,7 +56,7 @@ jobs:
5456
run: >
5557
cmake
5658
-B ${{github.workspace}}/build
57-
-DCMAKE_BUILD_TYPE=Release
59+
${{matrix.extra_build_option}}
5860
-DUMF_FORMAT_CODE_STYLE=OFF
5961
-DUMF_DEVELOPER_MODE=ON
6062
-DUMF_ENABLE_POOL_TRACKING=ON

.github/workflows/pr_push.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ jobs:
2020
pool_scalable: ['ON']
2121
disjoint: ['ON', 'OFF']
2222
jemalloc: ['ON']
23+
# Windows doesn't recognize 'CMAKE_BUILD_TYPE', it uses '--config' param in build command
24+
extra_build_option: ['-DCMAKE_BUILD_TYPE=Release']
2325
include:
2426
- os: windows-latest
2527
nproc: $Env:NUMBER_OF_PROCESSORS
@@ -42,7 +44,7 @@ jobs:
4244
run: >
4345
cmake
4446
-B ${{github.workspace}}/build
45-
-DCMAKE_BUILD_TYPE=Release
47+
${{matrix.extra_build_option}}
4648
-DUMF_FORMAT_CODE_STYLE=OFF
4749
-DUMF_DEVELOPER_MODE=ON
4850
-DUMF_ENABLE_POOL_TRACKING=ON

0 commit comments

Comments
 (0)