Do not free a pointer from another pool

Signed-off-by: Lukasz Dorau <[email protected]>

Author: ldorau

include/umf/base.h

@@ -47,6 +47,9 @@ typedef enum umf_result_t {
         6, ///< Failure in user provider code (i.e in user provided callback)
     UMF_RESULT_ERROR_DEPENDENCY_UNAVAILABLE =
         7, ///< External required dependency is unavailable or missing
+    UMF_RESULT_ERROR_INVALID_FREE_OP =
+        8, /*!< Invalid free operation - trying to free a pointer used by another
+                pool or a pointer belonging to another pool */
     UMF_RESULT_ERROR_UNKNOWN = 0x7ffffffe ///< Unknown or internal error
 } umf_result_t;
 

src/memory_pool.c

@@ -180,6 +180,14 @@ size_t umfPoolMallocUsableSize(umf_memory_pool_handle_t hPool, void *ptr) {
 
 umf_result_t umfPoolFree(umf_memory_pool_handle_t hPool, void *ptr) {
     UMF_CHECK((hPool != NULL), UMF_RESULT_ERROR_INVALID_ARGUMENT);
+    umf_memory_pool_handle_t poolTracker = umfMemoryTrackerGetPool(ptr);
+    if (poolTracker != NULL && poolTracker != hPool) {
+        LOG_ERR("invalid free operation: trying to free a pointer %p used by "
+                "another pool or belonging to another pool %p than the given "
+                "pool %p",
+                ptr, poolTracker, hPool);
+        return UMF_RESULT_ERROR_INVALID_FREE_OP;
+    }
     return hPool->ops.free(hPool->pool_priv, ptr);
 }