Fix condition in devdax_open_ipc_handle()

ldorau · ldorau · commit 3796e6f8d971 · 2024-09-16T09:26:32.000+02:00
Fix condition in devdax_open_ipc_handle().
os_devdax_open() returns -1 on error.
It fixes the Coverity issue no. 468935.

Signed-off-by: Lukasz Dorau &lt;lukasz.dorau@intel.com&gt;
diff --git a/src/provider/provider_devdax_memory.c b/src/provider/provider_devdax_memory.c
@@ -446,7 +446,7 @@ static umf_result_t devdax_open_ipc_handle(void *provider,
 
     umf_result_t ret = UMF_RESULT_SUCCESS;
     int fd = os_devdax_open(devdax_provider->path);
-    if (fd <= 0) {
+    if (fd == -1) {
         LOG_PERR("opening a devdax (%s) failed", devdax_provider->path);
         return UMF_RESULT_ERROR_INVALID_ARGUMENT;
     }

Original file line number	Diff line number	Diff line change
`@@ -446,7 +446,7 @@ static umf_result_t devdax_open_ipc_handle(void *provider,`
`446`	`446`
`447`	`447`	`umf_result_t ret = UMF_RESULT_SUCCESS;`
`448`	`448`	`int fd = os_devdax_open(devdax_provider->path);`
`449`		`- if (fd <= 0) {`
	`449`	`+ if (fd == -1) {`
`450`	`450`	`LOG_PERR("opening a devdax (%s) failed", devdax_provider->path);`
`451`	`451`	`return UMF_RESULT_ERROR_INVALID_ARGUMENT;`
`452`	`452`	`}`