Disable expensive debug checks

Expensive debug checks are under the ifdef from now:

#if !defined(NDEBUG) && defined(UMF_DEVELOPER_MODE)

Fixes: #1325

Signed-off-by: Lukasz Dorau <[email protected]>

Author: ldorau

src/base_alloc/base_alloc.c

@@ -66,7 +66,7 @@ struct umf_ba_next_pool_t {
     char data[];
 };
 
-#ifndef NDEBUG
+#if !defined(NDEBUG) && defined(UMF_DEVELOPER_MODE)
 static void ba_debug_checks(umf_ba_pool_t *pool) {
     // count pools
     size_t n_pools = 1;
@@ -89,7 +89,12 @@ static void ba_debug_checks(umf_ba_pool_t *pool) {
     }
     assert(n_free_chunks == pool->metadata.n_chunks - pool->metadata.n_allocs);
 }
-#endif /* NDEBUG */
+#else /* defined(NDEBUG) || !defined(UMF_DEVELOPER_MODE) */
+#define ba_debug_checks(pool)                                                  \
+    do {                                                                       \
+        (void)(pool); /* suppress unused variable warning */                   \
+    } while (0)
+#endif /* defined(NDEBUG) || !defined(UMF_DEVELOPER_MODE) */
 
 // ba_divide_memory_into_chunks - divide given memory into chunks of chunk_size and add them to the free_list
 static void ba_divide_memory_into_chunks(umf_ba_pool_t *pool, void *ptr,

src/coarse/coarse.c

@@ -130,7 +130,7 @@ static inline ravl_node_t *get_node_next(ravl_node_t *node) {
     return ravl_node_successor(node);
 }
 
-#ifndef NDEBUG
+#if !defined(NDEBUG) && defined(UMF_DEVELOPER_MODE)
 static block_t *get_block_prev(ravl_node_t *node) {
     ravl_node_t *ravl_prev = ravl_node_predecessor(node);
     if (!ravl_prev) {
@@ -148,7 +148,7 @@ static block_t *get_block_next(ravl_node_t *node) {
 
     return get_node_block(ravl_next);
 }
-#endif /* NDEBUG */
+#endif /* !defined(NDEBUG) && defined(UMF_DEVELOPER_MODE) */
 
 // The functions "coarse_ravl_*" handles the coarse->all_blocks list of blocks
 // sorted by a pointer (block_t->data) to the beginning of the block data.
@@ -527,7 +527,8 @@ static ravl_node_t *free_block_merge_with_next(coarse_t *coarse,
     return merged_node;
 }
 
-#ifndef NDEBUG // begin of DEBUG code
+// begin of DEBUG code
+#if !defined(NDEBUG) && defined(UMF_DEVELOPER_MODE)
 
 typedef struct debug_cb_args_t {
     coarse_t *provider;
@@ -606,7 +607,13 @@ static bool debug_check(coarse_t *provider) {
 
     return true;
 }
-#endif /* NDEBUG */ // end of DEBUG code
+#else  /* defined(NDEBUG) || !defined(UMF_DEVELOPER_MODE) */
+static inline bool debug_check(coarse_t *provider) {
+    (void)provider; // suppress unused variable warning
+    return true;
+}
+#endif /* defined(NDEBUG) || !defined(UMF_DEVELOPER_MODE) */
+// end of DEBUG code
 
 static umf_result_t coarse_add_used_block(coarse_t *coarse, void *addr,
                                           size_t size) {