Skip to content

Commit 67e6263

Browse files
authored
Merge pull request #1463 from ldorau/Add_assert_in_poolCreateExtUnique_after_EXPECT_
Add assert in `poolCreateExtUnique()` after `EXPECT_*()`
2 parents d55f3f3 + 6291602 commit 67e6263

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

test/poolFixtures.hpp

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ umf_test::pool_unique_handle_t poolCreateExtUnique(poolCreateExtParams params) {
4040
&upstream_provider);
4141
EXPECT_EQ(ret, UMF_RESULT_SUCCESS);
4242
EXPECT_NE(upstream_provider, nullptr);
43+
if (ret != UMF_RESULT_SUCCESS || upstream_provider == nullptr) {
44+
assert(false && "Failed to create a memory provider");
45+
return umf_test::pool_unique_handle_t(nullptr, nullptr);
46+
}
4347

4448
provider = upstream_provider;
4549

@@ -54,6 +58,10 @@ umf_test::pool_unique_handle_t poolCreateExtUnique(poolCreateExtParams params) {
5458
UMF_POOL_CREATE_FLAG_OWN_PROVIDER, &hPool);
5559
EXPECT_EQ(ret, UMF_RESULT_SUCCESS);
5660
EXPECT_NE(hPool, nullptr);
61+
if (ret != UMF_RESULT_SUCCESS || hPool == nullptr) {
62+
assert(false && "Failed to create a memory pool");
63+
return umf_test::pool_unique_handle_t(nullptr, nullptr);
64+
}
5765

5866
// we do not need params anymore
5967
if (poolParamsDestroy) {

0 commit comments

Comments
 (0)