build-docker-BasicBuilds

Author: rbanka1

.github/workflows/nightly.yml

@@ -2,10 +2,10 @@
 name: Nightly
 
 # This job is run at 00:00 UTC every day or on demand.
-on: workflow_call
-  # workflow_dispatch:
-  # schedule:
-  #   - cron:  '0 0 * * *'
+on:
+  workflow_dispatch:
+  schedule:
+    - cron:  '0 0 * * *'
 
 permissions:
   contents: read
@@ -27,32 +27,46 @@ jobs:
         with:
           fetch-depth: 0
 
-      # - name: Build Docker image
-      #   run: |
-      #     docker build -f .github/docker/ubuntu-20.04.Dockerfile -t umf-ubuntu-20.04 .   
-
-      - name: Fuzz long test in Docker container
+      - name: Install apt packages
         run: |
-          docker run --rm \
-            -v ${{github.workspace}}:/workspace \
-            -w /workspace \
-            --env BUILD_TYPE=${{matrix.build_type}} \
-            --user root \
-            umf-ubuntu-20.04 \
-            bash -c "
-              export VALGRIND_LIB=/usr/lib/valgrind/ &&
-              apt-get update &&
-              apt-get install -y cmake hwloc libhwloc-dev libnuma-dev libtbb-dev &&
-              cmake -B /workspace/build \
-                -DCMAKE_BUILD_TYPE=\$BUILD_TYPE \
-                -DCMAKE_C_COMPILER=${{matrix.compiler.c}} \
-                -DCMAKE_CXX_COMPILER=${{matrix.compiler.cxx}} \
-                -DUMF_TESTS_FAIL_ON_SKIP=ON \
-                -DUMF_DEVELOPER_MODE=ON \
-                -DUMF_BUILD_FUZZTESTS=ON &&
-              cmake --build /workspace/build --config \$BUILD_TYPE --verbose -j$(nproc) &&
-              ctest -C \$BUILD_TYPE --output-on-failure --verbose -L "fuzz-long"
-          "
+          sudo apt-get update
+          sudo apt-get install -y cmake hwloc libhwloc-dev libnuma-dev libtbb-dev
+
+      - name: Configure CMake
+        run: >
+          cmake
+          -B ${{github.workspace}}/build
+          -DCMAKE_BUILD_TYPE=${{matrix.build_type}}
+          -DCMAKE_C_COMPILER=${{matrix.compiler.c}}
+          -DCMAKE_CXX_COMPILER=${{matrix.compiler.cxx}}
+          -DUMF_TESTS_FAIL_ON_SKIP=ON
+          -DUMF_DEVELOPER_MODE=ON
+          -DUMF_BUILD_FUZZTESTS=ON
+
+      - name: Build
+        run: cmake --build ${{github.workspace}}/build --config ${{matrix.build_type}} --verbose -j$(nproc)
+
+      - name: Fuzz long test
+        working-directory: ${{github.workspace}}/build
+        run: ctest -C ${{matrix.build_type}} --output-on-failure --verbose -L "fuzz-long"
+
+  build-docker-BasicBuilds:
+    name: Build Docker image
+    needs: [FastBuild]
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+
+    - name: Build Docker image
+      run: |
+        docker build -f .github/docker/ubuntu-20.04.Dockerfile -t umf-ubuntu-20.04 .
+
+    - name: Run BasicBuilds
+      run: |
+        docker run --rm umf-ubuntu-20.04 sh -c "
+          gh workflow run ./.github/workflows/reusable_basic.yml \
+        "
 
   valgrind:
     name: Valgrind
@@ -68,34 +82,30 @@ jobs:
       with:
         fetch-depth: 0
 
-    # - name: Build Docker image
-    #   run: |
-    #     docker build -f .github/docker/ubuntu-20.04.Dockerfile -t umf-ubuntu-20.04 .
-
-    - name: Run tests under valgrind in Docker
+    - name: Install apt packages
       run: |
-        docker run --rm \
-          -v ${{github.workspace}}:/workspace \
-          -w /workspace \
-          --env TOOL=${{ matrix.tool }} \
-          --user root \
-          umf-ubuntu-20.04 \
-          bash -c "\
-            apt-get update &&
-            apt-get install -y cmake hwloc libhwloc-dev libnuma-dev libtbb-dev valgrind &&
-            cmake -B /workspace/build \
-              -DCMAKE_BUILD_TYPE=Debug \
-              -DUMF_FORMAT_CODE_STYLE=OFF \
-              -DUMF_DEVELOPER_MODE=ON \
-              -DUMF_BUILD_LIBUMF_POOL_DISJOINT=ON \
-              -DUMF_BUILD_LIBUMF_POOL_JEMALLOC=ON \
-              -DUMF_BUILD_LEVEL_ZERO_PROVIDER=OFF \
-              -DUMF_BUILD_CUDA_PROVIDER=OFF \
-              -DUMF_USE_VALGRIND=1 \
-              -DUMF_TESTS_FAIL_ON_SKIP=ON &&
-            cmake --build /workspace/build --config Debug -j$(nproc) &&
-            /workspace/test/test_valgrind.sh /workspace /workspace/build \$TOOL
-        "
+        sudo apt-get update
+        sudo apt-get install -y cmake hwloc libhwloc-dev libnuma-dev libtbb-dev valgrind
+
+    - name: Configure CMake
+      run: >
+        cmake
+        -B ${{github.workspace}}/build
+        -DCMAKE_BUILD_TYPE=Debug
+        -DUMF_FORMAT_CODE_STYLE=OFF
+        -DUMF_DEVELOPER_MODE=ON
+        -DUMF_BUILD_LIBUMF_POOL_DISJOINT=ON
+        -DUMF_BUILD_LIBUMF_POOL_JEMALLOC=ON
+        -DUMF_BUILD_LEVEL_ZERO_PROVIDER=OFF
+        -DUMF_BUILD_CUDA_PROVIDER=OFF
+        -DUMF_USE_VALGRIND=1
+        -DUMF_TESTS_FAIL_ON_SKIP=ON
+
+    - name: Build
+      run: cmake --build ${{github.workspace}}/build --config Debug -j$(nproc)
+
+    - name: Run tests under valgrind
+      run: ${{github.workspace}}/test/test_valgrind.sh ${{github.workspace}} ${{github.workspace}}/build ${{matrix.tool}}
 
   # TODO fix #843
   #icx:
@@ -201,4 +211,4 @@ jobs:
       short_run: false
       # Beside the 2 LTS Ubuntu, we also test this on the latest Ubuntu -  to be updated
       # every 6 months, so we verify the latest version of packages (compilers, etc.).
-      os: "['ubuntu-22.04', 'ubuntu-24.04', 'ubuntu-24.10']"
+      os: "['ubuntu-22.04', 'ubuntu-24.04', 'ubuntu-24.10']"

CMakeLists.txt

@@ -33,13 +33,6 @@ include(CMakePackageConfigHelpers)
 include(GNUInstallDirs)
 find_package(PkgConfig)
 
-find_package(Valgrind REQUIRED)
-if(Valgrind_FOUND)
-    message(STATUS "Found Valgrind!")
-else()
-    message(FATAL_ERROR "Valgrind not found!")
-endif()
-
 # Define a list to store the names of all options
 set(UMF_OPTIONS_LIST "")
 list(APPEND UMF_OPTIONS_LIST CMAKE_BUILD_TYPE)