Enable -Werror in developer build

Author: staniewzki

cmake/helpers.cmake

@@ -244,8 +244,9 @@ function(add_umf_target_compile_options name)
             target_compile_definitions(${name} PRIVATE -D_FORTIFY_SOURCE=2)
         endif()
         if(UMF_DEVELOPER_MODE)
-            target_compile_options(${name} PRIVATE -fno-omit-frame-pointer
-                                                   -fstack-protector-strong)
+            target_compile_options(
+                ${name} PRIVATE -fno-omit-frame-pointer
+                                -fstack-protector-strong -Werror)
         endif()
         if(UMF_USE_COVERAGE)
             if(NOT CMAKE_BUILD_TYPE STREQUAL "Debug")
@@ -279,6 +280,9 @@ function(add_umf_target_compile_options name)
                     # disable 4200 warning: nonstandard extension used:
                     # zero-sized array in struct/union
                     /wd4200)
+        if(UMF_DEVELOPER_MODE)
+            target_compile_options(${name} PRIVATE /WX)
+        endif()
         if(${CMAKE_C_COMPILER_ID} MATCHES "MSVC")
             target_compile_options(
                 ${name}

src/ipc_cache.c

@@ -89,7 +89,9 @@ umf_result_t umfIpcCacheGlobalInit(void) {
     return ret;
 }
 
-static size_t getGlobalLruListSize(lru_list_t lru_list) {
+// Removed `static, because of an unused function warning
+// TODO: restore static
+size_t getGlobalLruListSize(lru_list_t lru_list) {
     size_t size = 0;
     ipc_handle_cache_entry_t *tmp;
     DL_COUNT(lru_list, tmp, size);
@@ -216,7 +218,15 @@ umfIpcHandleMappedCacheGet(ipc_mapped_handle_cache_handle_t cache,
         entry->value.mapped_size = 0;
         entry->value.mapped_base_ptr = NULL;
 
+#ifdef _MSC_VER
+#pragma warning(disable : 4702)
+#endif
+        // HASH_ADD produces `warning C4702: unreachable code` on MSVC
         HASH_ADD(hh, cache->hash_table, key, sizeof(entry->key), entry);
+#ifdef _MSC_VER
+#pragma warning(default : 4702)
+#endif
+
         DL_PREPEND(cache->global->lru_list, entry);
         cache->global->cur_size += 1;
     }

src/memtargets/memtarget_numa.c

@@ -40,7 +40,7 @@ static umf_result_t numa_initialize(void *params, void **memTarget) {
         return UMF_RESULT_ERROR_OUT_OF_HOST_MEMORY;
     }
 
-    numaTarget->physical_id = config->physical_id;
+    numaTarget->physical_id = (unsigned)config->physical_id;
     *memTarget = numaTarget;
     return UMF_RESULT_SUCCESS;
 }
@@ -100,7 +100,7 @@ static umf_result_t numa_memory_provider_create_from_memspace(
 
             params.partitions =
                 (umf_numa_split_partition_t *)policy->ops.split.part;
-            params.partitions_len = policy->ops.split.part_len;
+            params.partitions_len = (unsigned)policy->ops.split.part_len;
             break;
         default:
             return UMF_RESULT_ERROR_INVALID_ARGUMENT;
@@ -131,7 +131,7 @@ static umf_result_t numa_memory_provider_create_from_memspace(
         for (size_t i = 0; i < numNodesProvider; i++) {
             params.numa_list[i] = numaTargets[i]->physical_id;
         }
-        params.numa_list_len = numNodesProvider;
+        params.numa_list_len = (unsigned)numNodesProvider;
     }
 
     umf_memory_provider_handle_t numaProvider = NULL;

src/provider/provider_devdax_memory.c

@@ -474,7 +474,7 @@ static umf_result_t devdax_open_ipc_handle(void *provider,
     LOG_DEBUG("devdax mapped (path: %s, size: %zu, protection: %i, fd: %i, "
               "offset: %zu) to address %p",
               devdax_ipc_data->path, length_aligned,
-              devdax_ipc_data->protection, fd, offset_aligned, addr);
+              devdax_ipc_data->protection, fd, offset_aligned, (void *)addr);
 
     *ptr = addr;
 

src/provider/provider_level_zero.c

@@ -148,12 +148,12 @@ static umf_result_t ze_memory_provider_initialize(void *params,
     }
 
     if ((ze_params->memory_type == UMF_MEMORY_TYPE_HOST) ==
-        (bool)ze_params->level_zero_device_handle) {
+        (ze_params->level_zero_device_handle != NULL)) {
         return UMF_RESULT_ERROR_INVALID_ARGUMENT;
     }
 
     if ((bool)ze_params->resident_device_count !=
-        (bool)ze_params->resident_device_handles) {
+        (ze_params->resident_device_handles != NULL)) {
         return UMF_RESULT_ERROR_INVALID_ARGUMENT;
     }
 

test/CMakeLists.txt

@@ -75,8 +75,11 @@ function(build_umf_test)
         # tests retrieve arguments using 'GetParam()', which applies a 'const'
         # qualifier often discarded in the test scenarios.
         target_compile_options(${TEST_TARGET_NAME} PRIVATE -Wno-cast-qual)
-    endif()
 
+        if(UMF_DEVELOPER_MODE)
+            target_compile_options(${TEST_TARGET_NAME} PRIVATE -Werror)
+        endif()
+    endif()
     target_link_directories(${TEST_TARGET_NAME} PRIVATE ${LIB_DIRS})
 
     target_include_directories(

test/ipc_os_prov_proxy.c

@@ -106,9 +106,9 @@ int main(int argc, char *argv[]) {
     }
 
     fprintf(stderr, "Allocated memory - %zu\n", size);
-    size_t val = 144;
-    size_t expected_val = val / 2;
-    *(size_t *)ptr = val;
+    unsigned long long val = 144;
+    unsigned long long expected_val = val / 2;
+    *(unsigned long long *)ptr = val;
 
     // get IPC handle of the allocation
     umf_ipc_handle_t ipc_handle = NULL;

test/poolFixtures.hpp

@@ -70,6 +70,11 @@ struct umfPoolTest : umf_test::test,
 
         auto [pool_ops, pool_params, provider_ops, provider_params,
               coarse_params] = this->GetParam();
+        (void)pool_ops;
+        (void)pool_params;
+        (void)provider_params;
+        (void)coarse_params;
+
         if (provider_ops == umfDevDaxMemoryProviderOps()) {
             char *path = getenv("UMF_TESTS_DEVDAX_PATH");
             if (path == nullptr || path[0] == 0) {