Changes

Author: ldorau

src/critnib/critnib.c

@@ -288,7 +288,7 @@ static void free_leaf(struct critnib *__restrict c,
         return;
     }
 
-    if (c->cb_free_leaf && k) {
+    if (c->cb_free_leaf && k && k->value) {
         c->cb_free_leaf(c->leaf_allocator, (void *)k->value);
     }
 
@@ -370,6 +370,10 @@ int critnib_insert(struct critnib *c, word key, void *value, int update) {
     word at = path ^ key;
     if (!at) {
         ASSERT(is_leaf(n));
+        if (to_leaf(kn)->value == value) {
+            // do not free the value
+            to_leaf(kn)->value = NULL;
+        }
         free_leaf(c, to_leaf(kn));
 
         if (update) {

src/provider/provider_tracking.c

@@ -709,7 +709,6 @@ static umf_result_t trackingFree(void *hProvider, void *ptr, size_t size) {
                     "size=%zu, ret = %d",
                     ptr, size, ret);
         }
-        umf_ba_global_free(value);
     }
 
     ret = umfMemoryProviderFree(p->hUpstream, ptr, size);
@@ -1110,14 +1109,12 @@ umf_memory_provider_ops_t UMF_TRACKING_MEMORY_PROVIDER_OPS = {
     .ipc.open_ipc_handle = trackingOpenIpcHandle,
     .ipc.close_ipc_handle = trackingCloseIpcHandle};
 
-/*
 static void free_ipc_cache_value(void *unused, void *ipc_cache_value) {
     (void)unused;
     if (ipc_cache_value) {
         umf_ba_global_free(ipc_cache_value);
     }
 }
-*/
 
 umf_result_t umfTrackingMemoryProviderCreate(
     umf_memory_provider_handle_t hUpstream, umf_memory_pool_handle_t hPool,
@@ -1131,8 +1128,7 @@ umf_result_t umfTrackingMemoryProviderCreate(
         return UMF_RESULT_ERROR_UNKNOWN;
     }
     params.pool = hPool;
-    // params.ipcCache = critnib_new(free_ipc_cache_value, NULL);
-    params.ipcCache = critnib_new(NULL, NULL);
+    params.ipcCache = critnib_new(free_ipc_cache_value, NULL);
     if (!params.ipcCache) {
         LOG_ERR("failed to create IPC cache");
         return UMF_RESULT_ERROR_OUT_OF_HOST_MEMORY;