Validate protection flag in DEVDAX provider params

Author: vinser52

src/provider/provider_devdax_memory.c

@@ -641,6 +641,16 @@ umf_result_t umfDevDaxMemoryProviderParamsSetProtection(
         return UMF_RESULT_ERROR_INVALID_ARGUMENT;
     }
 
+    // verify that protection contains only valid bits set
+    // (UMF_PROTECTION_MAX-1) - highest possible bit
+    // (UMF_PROTECTION_MAX-1) << 1 - next after highest possible bit
+    // ((UMF_PROTECTION_MAX-1) << 1) - 1 - all valid bits set
+    const unsigned VALID_FLAGS_ALL = ((UMF_PROTECTION_MAX - 1) << 1) - 1;
+    if (protection & ~VALID_FLAGS_ALL || protection == 0) {
+        LOG_ERR("Incorrect memory protection flags: %u", protection);
+        return UMF_RESULT_ERROR_INVALID_ARGUMENT;
+    }
+
     hParams->protection = protection;
 
     return UMF_RESULT_SUCCESS;

test/provider_devdax_memory.cpp

@@ -326,7 +326,47 @@ TEST_P(umfProviderTest, purge_force_INVALID_POINTER) {
                              UMF_DEVDAX_RESULT_ERROR_PURGE_FORCE_FAILED);
 }
 
-// negative tests
+// params tests
+
+TEST_F(test, params_protection_flag) {
+    umf_devdax_memory_provider_params_handle_t params = nullptr;
+    umf_result_t ret =
+        umfDevDaxMemoryProviderParamsCreate(&params, "/dev/dax0.0", 4096);
+    ASSERT_EQ(ret, UMF_RESULT_SUCCESS);
+    ASSERT_NE(params, nullptr);
+
+    //test all valid combinations
+    for (unsigned protection = UMF_PROTECTION_NONE;
+         protection < (UMF_PROTECTION_MAX - 1) << 1; ++protection) {
+        ret = umfDevDaxMemoryProviderParamsSetProtection(params, protection);
+        ASSERT_EQ(ret, UMF_RESULT_SUCCESS);
+    }
+
+    umfDevDaxMemoryProviderParamsDestroy(params);
+}
+
+// negative params tests
+
+TEST_F(test, params_invalid_protection_flag) {
+    umf_devdax_memory_provider_params_handle_t params = nullptr;
+    umf_result_t ret =
+        umfDevDaxMemoryProviderParamsCreate(&params, "/dev/dax0.0", 4096);
+    ASSERT_EQ(ret, UMF_RESULT_SUCCESS);
+    ASSERT_NE(params, nullptr);
+
+    ret = umfDevDaxMemoryProviderParamsSetProtection(params, 0);
+    ASSERT_EQ(ret, UMF_RESULT_ERROR_INVALID_ARGUMENT);
+
+    for (unsigned protection = UMF_PROTECTION_NONE;
+         protection < (UMF_PROTECTION_MAX - 1) << 1; ++protection) {
+        unsigned invalid_protection = protection | (UMF_PROTECTION_MAX << 1);
+        ret = umfDevDaxMemoryProviderParamsSetProtection(params,
+                                                         invalid_protection);
+        ASSERT_EQ(ret, UMF_RESULT_ERROR_INVALID_ARGUMENT);
+    }
+
+    umfDevDaxMemoryProviderParamsDestroy(params);
+}
 
 TEST_F(test, params_null_handle) {
     auto ret =