corrections V3

Author: rbanka1

.github/docker/ubuntu-20.04.Dockerfile

@@ -22,11 +22,6 @@ ARG BASE_DEPS="\
 	cmake \
 	git"
 
-# UMF's dependencies
-ARG UMF_DEPS="\
-	libhwloc-dev \
-	libtbb-dev"
-
 # Dependencies for tests (optional)
 ARG TEST_DEPS="\
 	libnuma-dev \

.github/docker/ubuntu-22.04.Dockerfile

@@ -22,11 +22,6 @@ ARG BASE_DEPS="\
 	cmake \
 	git"
 
-# UMF's dependencies
-ARG UMF_DEPS="\
-	libhwloc-dev \
-	libtbb-dev"
-
 # Dependencies for tests (optional)
 ARG TEST_DEPS="\
 	libnuma-dev \

.github/docker/ubuntu-24.04.Dockerfile

@@ -22,11 +22,6 @@ ARG BASE_DEPS="\
 	cmake \
 	git"
 
-# UMF's dependencies
-ARG UMF_DEPS="\
-	libhwloc-dev \
-	libtbb-dev"
-
 # Dependencies for tests (optional)
 ARG TEST_DEPS="\
 	libnuma-dev \
@@ -75,4 +70,4 @@ RUN pip3 install --no-cache-dir --break-system-packages -r /opt/umf/requirements
 ENV USER test_user
 ENV USERPASS pass
 RUN useradd -m "${USER}" -g sudo -p "$(mkpasswd ${USERPASS})"
-USER test_user
+USER test_user

.github/workflows/pr_push.yml

@@ -23,42 +23,31 @@ jobs:
     uses: ./.github/workflows/reusable_docs_build.yml
   DetectChanges:
     runs-on: ubuntu-latest
-    outputs: 
-      changed_files: ${{ steps.get-changes.outputs.all_changed_files }}
+    outputs:
+      changed_files: ${{ steps.changed-files.outputs.all_changed_files }}
     steps:
       - name: Checkout code
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
         with:
-          fetch-depth: 2
+          fetch-depth: 0
 
-      - name: List all changed files
-        id: get-changes
-        run: |
-          git diff --name-only HEAD^ HEAD > all_changed_files.txt
-          changed_files=$(cat all_changed_files.txt | tr '\n' ' ')
-          echo "changed_files=$changed_files" >> $GITHUB_ENV
-          echo "::set-output name=all_changed_files::$changed_files"
+      - name: Get changed files
+        id: changed-files
+        uses: tj-actions/[email protected]
 
-      - name: all changed files
-        run: |
-          echo "changed files: ${{ needs.DetectChanges.outputs.changed_files }}"
-  Check:
-    runs-on: ubuntu-latest
-    needs: [DetectChanges]
-    steps: 
-      - name: check changed files
+      - name: List all changed files
+        env:
+          ALL_CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
         run: |
-          echo "all_changed_files: ${{ needs.DetectChanges.outputs.changed_files }}"
-          echo "all_changed_files: ${{ contains(join(needs.DetectChanges.outputs.changed_files, ' '), '.github/docker/') }}"
-
+          echo "Changed files: ${{ steps.changed-files.outputs.all_changed_files }}"
   BuildDockers:
     if: ${{ contains(join(needs.DetectChanges.outputs.changed_files, ' '), '.github/docker/') }}
     needs: [DetectChanges]
     permissions:
       contents: read
       packages: write
     secrets: inherit
-    uses: ./.github/workflows/build_dockers.yml
+    uses: ./.github/workflows/reusable_dockers_build.yml
   FastBuild:
     if: always() && (needs.BuildDockers.result == 'skipped' || needs.BuildDockers.result == 'success')
     needs: [ CodeChecks, DocsBuild, BuildDockers]

.github/workflows/build_dockers.yml renamed to .github/workflows/reusable_dockers_build.yml

@@ -18,8 +18,7 @@ jobs:
     outputs: 
       status: ${{ job.status }}
     env:
-      GHCR_TOKEN: ${{ secrets.BB_GHCR_TOKEN }} # ${{ secrets.GHCR_TOKEN }}
-      IMG: ghcr.io/${{ github.bb-ur }}/umf-ubuntu-${{ matrix.ubuntu-version }}:latest
+      IMG: ghcr.io/bb-ur/umf-ubuntu-${{ matrix.ubuntu-version }}:latest
 
     steps:
       - name: Checkout repository
@@ -31,10 +30,10 @@ jobs:
         uses: docker/login-action@30f019fb76bb54d03ec1e716054622be511a13b2 # v3.2.0
         with: 
           registry: ghcr.io
-          username: ${{ github.bb-ur }} # ${{ github.actor }}
-          password: ${{ env.BB_GHCR_TOKEN }} # ${{ env.GHCR_TOKEN }}
+          username: bb-ur
+          password: ${{ secrets.BB_GHCR_TOKEN }}
 
       - name: Build and push ubuntu-${{ matrix.ubuntu-version }} Docker image
         run: |
           docker build -f .github/docker/ubuntu-${{ matrix.ubuntu-version }}.Dockerfile -t ${{ env.IMG }} .
-          docker push ${{ env.IMG }}
+          docker push ${{ env.IMG }}

.github/workflows/reusable_fast.yml

@@ -16,27 +16,27 @@ jobs:
     name: Linux
     runs-on: ${{ github.repository_owner == 'oneapi-src' && 'intel-ubuntu-22.04' || 'ubuntu-22.04' }}
     container:
-      image: ${{ matrix.image }}
+      image: ghcr.io/bb-ur/umf-ubuntu-${{ matrix.ubuntu_ver }}:latest
       options: --user root --privileged
       volumes:
         - ${{ github.workspace }}:${{ github.workspace }}
     strategy:
       matrix:
         include:
-          - image: ghcr.io/rbanka1/umf-ubuntu-22.04:latest
+          - ubuntu_ver: 22.04
             build_tests: 'ON'
             extra_build_options: ' -DUMF_BUILD_BENCHMARKS=ON -DUMF_BUILD_BENCHMARKS_MT=ON'
             simple_cmake: 'OFF'
           # pure C build
-          - image: ghcr.io/rbanka1/umf-ubuntu-22.04:latest
+          - ubuntu_ver: 22.04
             build_tests: 'OFF'
             extra_build_options: '-DUMF_BUILD_BENCHMARKS=ON'
             simple_cmake: 'OFF'
           # simplest CMake on ubuntu-latest
-          - image: ghcr.io/rbanka1/umf-ubuntu-22.04:latest
+          - ubuntu_ver: 24.04
             build_tests: 'ON'
             simple_cmake: 'ON'
-          - image: ghcr.io/rbanka1/umf-ubuntu-20.04:latest
+          - ubuntu_ver: 20.04
             build_tests: 'ON'
             simple_cmake: 'ON'
 
@@ -97,8 +97,8 @@ jobs:
             simple_cmake: 'OFF'
           - build_tests: 'OFF'
             simple_cmake: 'OFF'
-          # - build_tests: 'OFF'
-          #   simple_cmake: 'ON'
+          - build_tests: 'OFF'
+            simple_cmake: 'ON'
 
     steps:
     - name: Checkout repository
@@ -140,6 +140,7 @@ jobs:
         cmake
         -B ${{env.BUILD_DIR}}
         -DCMAKE_INSTALL_PREFIX="${{env.INSTL_DIR}}"
+        -DCMAKE_PREFIX_PATH="${{env.VCPKG_PATH}}"
         -DUMF_BUILD_SHARED_LIBRARY=ON
         -DUMF_TESTS_FAIL_ON_SKIP=ON
 
@@ -161,4 +162,4 @@ jobs:
     - name: Print metadata of our dll's
       run: |
         get-command ${{github.workspace}}/build/bin/Release/umf.dll | format-list
-        get-command ${{github.workspace}}/build/src/proxy_lib/Release/umf_proxy.dll | format-list
+        get-command ${{github.workspace}}/build/src/proxy_lib/Release/umf_proxy.dll | format-list