Skip to content

Commit d3ed8a1

Browse files
UT_ASSERTs successfully substituted - going to work on return and IsSkipped
1 parent 65841bf commit d3ed8a1

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

test/common/test_helpers.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,7 @@ static inline bool UT_LOG_ERR(const char *format, ...) {
5555

5656
#define GTEST_OUT_EQ(lhs, rhs) \
5757
((bool)(((lhs) == (rhs)) || \
58-
(UT_LOG_ERR("%s:%d %s - assertion failure\n\
59-
Expected: %s == %s, actual: (0x%llx) vs (0x%llx)" \
58+
(UT_LOG_ERR("%s:%d %s - assertion failure\nExpected: %s == %s, actual: (0x%llx) vs (0x%llx)" \
6059
, \
6160
__FILE__, __LINE__, __func__, #lhs, \
6261
#rhs, (unsigned long long)(lhs), \

test/memspaces/memspace_lowest_latency.cpp

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,17 @@ static bool canQueryLatency(size_t nodeId) {
3636
return false;
3737
}
3838
ret = hwloc_topology_load(topology);
39-
UT_ASSERTeq(ret, 0);
39+
//UT_ASSERTeq(ret, 0);
40+
if (!(GTEST_OUT_EQ(ret, 0))) {
41+
return false;
42+
}
4043

4144
hwloc_obj_t numaNode =
4245
hwloc_get_obj_by_type(topology, HWLOC_OBJ_NUMANODE, nodeId);
43-
UT_ASSERTne(numaNode, nullptr);
46+
//UT_ASSERTne(numaNode, nullptr);
47+
if (!(GTEST_OUT_NE(numaNode, nullptr))) {
48+
return false;
49+
}
4450

4551
// Setup initiator structure.
4652
struct hwloc_location initiator;

0 commit comments

Comments
 (0)