Skip to content

Commit de0f516

Browse files
First beautiful comment
1 parent 8e1317a commit de0f516

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

test/memspaces/memspace_lowest_latency.cpp

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,7 @@
1010
#include "test_helpers.h"
1111

1212
/*
13-
14-
canQueryLatency is used in a parameter generator as a functional pointer
15-
https://man.archlinux.org/man/hwloc_memattr_get_value.3.en
16-
0 on success - hwloc_memattr_get_value
17-
assume overall failure
18-
expect instead of add_failure: more verbosity
13+
canQueryLatency is used in a parameter generator as a functional pointer and is not a standalone test, thus it cannot contain GTEST asserts. EXPECT_* or ADD_FAILURE() do not cancel the execution of the code following after, but they interfere with GTEST_SKIP() in fixtures: the execution of the tests included in the suite assigned to the given fixture is not cancelled if EXPECT_* or ADD_FAILURE() are used. Therefore a custom logging macro is used.
1914
*/
2015

2116
static bool canQueryLatency(size_t nodeId) {

0 commit comments

Comments
 (0)