final version v2

Author: rbanka1

.github/workflows/reusable_checks.yml

@@ -1,5 +1,4 @@
 # Basic checks on the code, incl. coding style, spelling, bandit analysis.
-# TODO: add license check
 name: Basic checks
 
 on: workflow_call

CMakeLists.txt

@@ -175,15 +175,6 @@ else()
     add_custom_target(jemalloc_prod
                       DEPENDS ${jemalloc_targ_BINARY_DIR}/lib/libjemalloc.a)
 
-    add_custom_target(
-        check-license
-        COMMAND ${UMF_CMAKE_SOURCE_DIR}/check_license/check-headers.sh
-                ${UMF_CMAKE_SOURCE_DIR} Apache-2.0 WITH LLVM-exception -v)
-    add_custom_target(
-        copyright-format
-        COMMAND ${UMF_CMAKE_SOURCE_DIR}/check_license/check-headers.sh
-                ${UMF_CMAKE_SOURCE_DIR} Apache-2.0 WITH LLVM-exception -d)
-
     add_library(jemalloc INTERFACE)
     target_link_libraries(
         jemalloc INTERFACE ${jemalloc_targ_BINARY_DIR}/lib/libjemalloc.a)

check_license/check-headers.sh

@@ -84,8 +84,6 @@ else
 	GIT_COMMAND="diff --name-only $MERGE_BASE $CURRENT_COMMIT"
 fi
 
-chmod +x "${SOURCE_ROOT}/check_license/file-exceptions.sh"
-
 FILES=$($GIT $GIT_COMMAND | ${SOURCE_ROOT}/check_license/file-exceptions.sh)
 
 RV=0
@@ -188,5 +186,4 @@ if [ $RV -eq 0 ]; then
 else
 	echo "Error(s) in copyright headers found!" >&2
 fi
-exit $RV
-
+exit $RV

check_license/file-exceptions.sh

@@ -4,7 +4,7 @@
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
 # You can add an exception file
-grep -v -E -e '/src/uthash/.*' \
+grep -v -E -e 'src/uthash/.*' \
            -e 'benchmark/ubench.h' \
            -e 'include/umf/proxy_lib_new_delete.h' \
            -e 'scripts/docs_config/conf.py' \
@@ -17,7 +17,7 @@ grep -v -E -e '/src/uthash/.*' \
            -e 'CODEOWNERS$' \
            -e 'scripts/assets/images/.*' \
            -e 'scripts/docs_config/.*' \
-           -e 'scripts/qemu/configs/.*' \
+           -e '\.xml$' \
            -e '\.txt$' \
            -e 'test/supp/.*' \
            -e '\.json$' \
@@ -29,6 +29,3 @@ grep -v -E -e '/src/uthash/.*' \
            -e 'ChangeLog' \
            -e '\.cmake.in$' \
            -e '\.patch$'
-
-
-