Skip to content

Commit fab9ac5

Browse files
Some hints on solution: isSkipped does not work, but usi
ng getParam from superclass: works
1 parent d25ebc8 commit fab9ac5

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

test/memspaces/memspace_fixtures.hpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,11 @@ struct memspaceProviderTest : ::memspaceGetTest {
8080
void SetUp() override {
8181
::memspaceGetTest::SetUp();
8282

83+
auto [isQuerySupported, memspaceGet] = ::memspaceGetTest::GetParam();
84+
bool restinpiss = isQuerySupported(nodeIds.front());
85+
ASSERT_TRUE(false) << "is skipped?" << ::memspaceGetTest::IsSkipped() << " | res: " << restinpiss;
8386
if (::memspaceGetTest::IsSkipped()) {
87+
// it uses a method from superclass as its own, so fuck you
8488
GTEST_SKIP();
8589
}
8690

test/memspaces/memspace_lowest_latency.cpp

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,20 @@
1414
canQueryLatency is used in a parameter generator as a functional pointer
1515
https://man.archlinux.org/man/hwloc_memattr_get_value.3.en
1616
0 on success - hwloc_memattr_get_value
17+
assume overall failure
18+
expect instead of add_failure: more verbosity
1719
*/
1820

1921
static bool canQueryLatency(size_t nodeId) {
2022
hwloc_topology_t topology = nullptr;
2123
int ret = hwloc_topology_init(&topology);
2224
// UT_ASSERTeq(ret, 0);
23-
EXPECT_NE(ret, 0);
25+
// EXPECT_NE(ret, 0);
26+
if (ret == 0) {
27+
//ADD_FAILURE();
28+
EXPECT_NE(ret, 0);
29+
return true; //false;
30+
}
2431
ret = hwloc_topology_load(topology);
2532
UT_ASSERTeq(ret, 0);
2633

0 commit comments

Comments
 (0)