Fix node_list_rm_first() and node_list_rm_with_alignment() in the coarse library
#1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
approved these changes
Feb 20, 2025
Fix checking alignment in the following functions of the coarse library: - node_list_rm_first() and - node_list_rm_with_alignment() In order to check the alignment we have to verify an address of the block (block->data), not a size (block->size) of course ... Signed-off-by: Lukasz Dorau <[email protected]>
Add a test for not aligned fixed memory buffer: - coarseTest_basic_non_aligned_fixed_memory Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Fix_node_list_rm_first_and_node_list_rm_with_alignment
branch
from
55b6b8c to
d6c5327
Compare
lukaszstolarczuk
approved these changes
Feb 21, 2025
ldorau
deleted the
Fix_node_list_rm_first_and_node_list_rm_with_alignment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
node_list_rm_first()andnode_list_rm_with_alignment()in the coarse library.Add the
coarseTest_basic_non_aligned_fixed_memorytest.Checklist