Fix Valgrind and TSAN instrumentation #1138
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I see that TSAN passed .. maybe there annotation should be placed differently for TSAN and Valgrind? |
Contributor
|
I'm 99% sure that issue is that this two macros are "empty" unified-memory-framework/src/utils/utils_common.h Lines 56 to 57 in 113f3e0 While we should call ANNOTATE_NEW_MEMORY and VALGRIND_HG_DISABLE_CHECKING and ANNOTATE_NEW_MEMORY |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Valgrind and TSAN instrumentation.
Ref. #886
Checklist