Skip to content

Conversation

@lplewa
Copy link
Contributor

@lplewa lplewa commented Mar 17, 2025

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used
  • All API changes are reflected in docs and def/map files, and are tested

@lplewa lplewa requested a review from a team as a code owner March 17, 2025 13:55
Copy link
Contributor

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you describe in commit message what this patch changes and why?

@lplewa
Copy link
Contributor Author

lplewa commented Mar 17, 2025

Could you describe in commit message what this patch changes and why?

Is just fix for a typo

@lukaszstolarczuk
Copy link
Contributor

Could you describe in commit message what this patch changes and why?

Is just fix for a typo

this is the craziest typo I've ever seen 😄

@ldorau
Copy link
Contributor

ldorau commented Mar 17, 2025

Could you describe in commit message what this patch changes and why?

Is just fix for a typo

so why did it work with this "typo" ?

@lplewa
Copy link
Contributor Author

lplewa commented Mar 17, 2025

Could you describe in commit message what this patch changes and why?

Is just fix for a typo

so why did it work with this "typo" ?

We had benchmarks with os_provider. I copied them, and updated to use fixed provider. In one place i did not renamed benchmark object in register function. So we registered jemalloc<os_provider> twice instead, and benchmark object for jemalloc<fixed_provider> was not registered/used.

@lukaszstolarczuk lukaszstolarczuk requested a review from ldorau March 17, 2025 16:14
@lplewa
Copy link
Contributor Author

lplewa commented Mar 17, 2025

Before the patch
image
After the patch
image

@ldorau ldorau merged commit 9a93b20 into oneapi-src:main Mar 17, 2025
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants