Skip to content

Conversation

@KFilipek
Copy link
Contributor

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used
  • All API changes are reflected in docs and def/map files, and are tested

PatKamin and others added 30 commits March 6, 2025 12:17
For tag checkout it's no surprise; for main we print full version
during 'Configure' step.
[CI] Fix failing address sanitizer
…andling_path_of_umf_ba_alloc

Add missing `unlock()` in an error handling path of `umf_ba_alloc()`
Extend compatibility tests with GPU runners
Enable MT bench for disjoint_pool in fixed provider
check for alloc fails in disjoint pool init
Run Compatibility GPU CI jobs only on upstream,
since forks do not have the required HW.

Signed-off-by: Lukasz Dorau <[email protected]>
It fixes ThreadSanitizer data race in find_predecessor()
vs critnib_insert() and critnib_remove().

Signed-off-by: Lukasz Dorau <[email protected]>
Check valgrind log files. Do not print an error message like:

ls: cannot access './examples/umf_example_*.log': No such file or directory

when only the tests log files are present for example.

Signed-off-by: Lukasz Dorau <[email protected]>
…ly_on_upstream

Run Compatibility GPU CI jobs only on upstream
add missing nullcheck in critnib
Use atomics in find_successor() like in find_predecessor().

Ref: #1175

Signed-off-by: Lukasz Dorau <[email protected]>
Multilevel maps are needed to support the case
when one memory pool acts as a memory provider
for another memory pool (nested memory pooling).

Signed-off-by: Lukasz Dorau <[email protected]>
ldorau and others added 25 commits March 12, 2025 18:50
…error_in_cu2umf_result

Handle `CUDA_ERROR_DEINITIALIZED` error in `cu2umf_result()`
Fix segfault in cu_memory_provider_get_last_native_error()
when it is called after a CUDA device was destroyed.

Signed-off-by: Lukasz Dorau <[email protected]>
[CI] Enable SLES in multi numa workflow
…er_get_last_native_error

Fix segfault in `cu_memory_provider_get_last_native_error()`
use current ctx and dev by default in CUDA prov
Move C++ helper header to utils
…ixed_provider

Enable jemalloc pool test with Fixed provider
Install libnuma-dev in the proxy lib workflow,
because it is required.

It has worked correctly so far most probably,
because libnuma-dev has been installed
as a dependency of libhwloc-dev.
It failed when libhwloc-dev was not installed.

Signed-off-by: Lukasz Dorau <[email protected]>
…_lib_workflow

Install libnuma-dev in the proxy lib workflow
Suppress false-positive in IPC tests under helgrind
Remove old SHM files /tmp/umf_file_provider_*
(at the beginning of the test)
left from the previous runs, because of crashes
of the ipc_file_prov test.

Signed-off-by: Lukasz Dorau <[email protected]>
…he_previous_runs_because_of_crashes

Remove old SHM files left from the previous runs because of crashes
fix jemalloc benchmark with fixedprovider
Fallback to fetching hwloc from source instead of failing UMF build.
Add a workflow for testing the fallback.
Unify correct paths to hwloc.
Use target name instead of a library path for hwloc linkage.
increase number of threads in benchmarks
Fallback to hwloc fetch if package not found
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

pip install --force-reinstall -r ${{github.workspace}}/sycl-repo/unified-runtime/third_party/benchmark_requirements.txt
python -m venv .venv
source .venv/bin/activate
pip install -r ${{github.workspace}}/sycl-repo/unified-runtime/third_party/benchmark_requirements.txt

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 7: pipCommand not pinned by hash
Click Remediation section below to solve this issue
limit benchmark test to singlethreaded one only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants