add missing const in external umf api #1257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lplewa
force-pushed
the
const_api
branch
3 times, most recently
from
26e2716 to
dc6d570
Compare
bratpiorka
reviewed
Apr 11, 2025
bratpiorka
reviewed
Apr 11, 2025
bratpiorka
reviewed
Apr 11, 2025
| // in an mmap call like this: | ||
| // mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0) | ||
| umf_memory_provider_ops_t *provider_ops = umfOsMemoryProviderOps(); | ||
| const umf_memory_provider_ops_t *provider_ops = umfOsMemoryProviderOps(); |
Contributor
There was a problem hiding this comment.
compat tests should fail here - I need to investigate this
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
/home/runner/work/unified-memory-framework/unified-memory-framework/tag_version/examples/basic/basic.c: In function ‘main’:
/home/runner/work/unified-memory-framework/unified-memory-framework/tag_version/examples/basic/basic.c:25:47: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
25 | umf_memory_provider_ops_t *provider_ops = umfOsMemoryProviderOps();
| ^~~~~~~~~~~~~~~~~~~~~~
/home/runner/work/unified-memory-framework/unified-memory-framework/tag_version/examples/basic/basic.c:72:39: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
72 | umf_memory_pool_ops_t *pool_ops = umfScalablePoolOps();
| ^~~~~~~~~~~~~~~~~~
KFilipek
approved these changes
Apr 14, 2025
bratpiorka
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1080
Description
Checklist