Skip to content

[CTL] Add size check for umfCtlExec #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukaszstolarczuk merged 1 commit into from
Jun 11, 2025
Merged

[CTL] Add size check for umfCtlExec #1363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/libumf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,10 @@ umf_result_t umfCtlExec(const char *name, void *ctx, void *arg, size_t size) {
return UMF_RESULT_ERROR_INVALID_ARGUMENT;
}

if ((arg == NULL && size != 0) || (arg != NULL && size == 0)) {
return UMF_RESULT_ERROR_INVALID_ARGUMENT;
}

return ctl_query(NULL, ctx, CTL_QUERY_PROGRAMMATIC, name,
CTL_QUERY_RUNNABLE, arg, size)
? UMF_RESULT_ERROR_UNKNOWN
Expand Down
8 changes: 8 additions & 0 deletions test/ctl/ctl_api.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,14 @@ TEST_F(CtlTest, ctlSizeValidation) {
p.freeResources();
}

TEST_F(CtlTest, ctlExecInvalidSize) {
std::string name = "umf.pool.default.disjoint.name";
ASSERT_EQ(umfCtlSet(name.c_str(), NULL, (void *)"test_value", 0),
UMF_RESULT_ERROR_INVALID_ARGUMENT);
ASSERT_EQ(umfCtlSet(name.c_str(), NULL, NULL, 10),
UMF_RESULT_ERROR_INVALID_ARGUMENT);
}

#ifdef PROVIDER_DEFAULTS_NOT_IMPLEMENTED_YET
TEST_F(CtlTest, ctlDefaultMultithreadedProvider) {
std::vector<std::thread> threads;
Expand Down
Loading