Several CI changes #1364
Merged
Several CI changes #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
approved these changes
Jun 10, 2025
lukaszstolarczuk
force-pushed
the
ci-changes
branch
2 times, most recently
from
363d746 to
31b0527
Compare
|
After all, clang-cl worked fine with Ninja, but changed the CMake to default one, plus the Debug build. Also, the CMake 3.14 build was making problems, temporarily removed - it's still tested on Linux |
lukaszstolarczuk
force-pushed
the
ci-changes
branch
from
31b0527 to
dcb3753
Compare
ldorau
approved these changes
Jun 12, 2025
Including a "fix" to run it in finite time, instead of counting on GHA's timeout. Thanks to that we can have a status badge, showing if the job is actually green or not. Also, re-name this workflow to 'weekly', to be more generic and open for other jobs.
Use 'latest' label where we don't care about a specific Win version. Update clang-cl Windows build to use Ninja - VS and (default) NMake were making problems.
lukaszstolarczuk
force-pushed
the
ci-changes
branch
from
dcb3753 to
79e64f6
Compare
bratpiorka
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Most important changes are:
Checklist