Skip to content

[disjoint] Set default parameters for disjoint pool #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2025
Merged

[disjoint] Set default parameters for disjoint pool #1377

merged 2 commits into from
Jul 1, 2025

Conversation

@KFilipek
Copy link
Contributor

@KFilipek KFilipek commented Jun 13, 2025 •
edited by bratpiorka
Loading

Description

fixes #804

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used
  • All API changes are reflected in docs and def/map files, and are tested

@KFilipek KFilipek self-assigned this Jun 13, 2025
@KFilipek KFilipek requested a review from a team as a code owner June 13, 2025 12:56
lplewa
lplewa reviewed Jun 16, 2025
View reviewed changes
lplewa
lplewa reviewed Jun 16, 2025
View reviewed changes
@KFilipek KFilipek requested review from bratpiorka and lplewa June 18, 2025 13:12
bratpiorka
bratpiorka reviewed Jun 18, 2025
View reviewed changes
bratpiorka
bratpiorka reviewed Jun 18, 2025
View reviewed changes
bratpiorka
bratpiorka reviewed Jun 24, 2025
View reviewed changes
bratpiorka
bratpiorka reviewed Jun 24, 2025
View reviewed changes
bratpiorka
bratpiorka reviewed Jun 24, 2025
View reviewed changes
@KFilipek KFilipek force-pushed the disjoint-nonnull branch 3 times, most recently from 11cfa4b to 2daaefa Compare June 27, 2025 14:43
@KFilipek KFilipek requested a review from bratpiorka June 27, 2025 14:53
bratpiorka
bratpiorka reviewed Jun 30, 2025
View reviewed changes
@KFilipek
Copy link
Contributor Author

KFilipek commented Jun 30, 2025

Rebased due to changes in CI.

@KFilipek KFilipek force-pushed the disjoint-nonnull branch from 3ab5fbb to da78dae Compare July 1, 2025 12:56
@KFilipek KFilipek changed the title [disjoint] Set default parameters for disjoint pool WIP - DO NOT MERGE [disjoint] Set default parameters for disjoint pool Jul 1, 2025
@KFilipek KFilipek force-pushed the disjoint-nonnull branch from 315087f to b350c05 Compare July 1, 2025 14:38
@KFilipek KFilipek changed the title WIP - DO NOT MERGE [disjoint] Set default parameters for disjoint pool [disjoint] Set default parameters for disjoint pool Jul 1, 2025
@KFilipek
Copy link
Contributor Author

KFilipek commented Jul 1, 2025

I've fixed also failing test on L0-BMG due to changes in default values.

@KFilipek KFilipek merged commit 95b4c6d into oneapi-src:main Jul 1, 2025
81 checks passed
@lukaszstolarczuk lukaszstolarczuk mentioned this pull request Jul 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bratpiorka bratpiorka bratpiorka approved these changes

@lplewa lplewa lplewa approved these changes

Assignees

@KFilipek KFilipek

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disjointpool seqfaults if parameters are NULL.

3 participants

@KFilipek @bratpiorka @lplewa