[CI] SLES 15 sp 5 #1433
Closed
[CI] SLES 15 sp 5 #1433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a SLES 15 test variant to the reusable_multi_numa GitHub Actions workflow matrix.
- Extends the
osmatrix to includesles-15-test - Retains a TODO about bringing back SLES-15 once machines are ready
Comments suppressed due to low confidence (2)
.github/workflows/reusable_multi_numa.yml:22
- The identifier
sles-15-testis ambiguous; consider renaming it to match the actual OS version (e.g.,sles-15-sp5) to align with naming conventions.
os: [ubuntu-22.04, rhel-9.1, sles-15-test]
.github/workflows/reusable_multi_numa.yml:21
- [nitpick] This TODO may now be outdated since a SLES variant has been added. Consider updating or removing it to avoid confusion.
# TODO: bring back SLES-15 when the machine is ready
opensource-krzysztof
requested review from
bratpiorka,
ldorau,
lukaszstolarczuk and
pbalcer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not merge testing