Skip to content

Conversation

@lplewa
Copy link
Contributor

@lplewa lplewa commented Jul 15, 2025

cont. #1430

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used
  • All API changes are reflected in docs and def/map files, and are tested

@lplewa lplewa requested a review from a team as a code owner July 15, 2025 13:47
Copy link
Contributor

@kswiecicki kswiecicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You could comment out the name ctl tests that are disabled.
Or will they be filtered out with gtest filter when running CI?

@lplewa
Copy link
Contributor Author

lplewa commented Jul 15, 2025

nit: You could comment out the name ctl tests that are disabled. Or will they be filtered out with gtest filter when running CI?

Its gtest feature - if you call test DISABLED it is disabled

@bratpiorka bratpiorka merged commit 9c35d11 into oneapi-src:main Jul 15, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants