-
Notifications
You must be signed in to change notification settings - Fork 42
add ctl_stats to remaining providers #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/provider/provider_file_memory.c
Outdated
| #include <umf/memory_provider_ops.h> | ||
| #include <umf/providers/provider_file_memory.h> | ||
|
|
||
| #include "provider_ctl_stats_type.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this include
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds control statistics (ctl_stats) support to the remaining memory providers in the UMF (Unified Memory Framework) library. The implementation enables tracking of allocated memory, peak memory usage, and provides a reset mechanism for peak memory statistics across all provider types.
- Extends ctl_stats functionality to CUDA, Level Zero, file memory, devdax memory, OS memory, and fixed memory providers
- Adds comprehensive test coverage for ctl_stats functionality across all provider types
- Implements consistent memory tracking and peak memory reset operations for all providers
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/provider/provider_cuda.c | Adds ctl_stats implementation with memory tracking in alloc/free operations |
| src/provider/provider_level_zero.c | Implements helper functions to enable/disable stats tracking and adds ctl_stats support |
| src/provider/provider_file_memory.c | Integrates ctl_stats tracking into coarse allocation/deallocation operations |
| src/provider/provider_devdax_memory.c | Adds ctl_stats support with memory tracking in devdax provider operations |
| test/provider_os_memory.cpp | Adds comprehensive ctl_stats test coverage for OS memory provider |
| test/provider_fixed_memory.cpp | Implements ctl_stats test suite for fixed memory provider |
| test/provider_file_memory.cpp | Adds ctl_stats testing for file memory provider |
| test/provider_devdax_memory.cpp | Implements ctl_stats test coverage for devdax memory provider |
| test/providers/provider_cuda.cpp | Adds comprehensive ctl_stats test suite for CUDA provider |
| test/providers/provider_level_zero.cpp | Implements ctl_stats testing for Level Zero provider |
Description
Checklist