Skip to content

Conversation

@lplewa
Copy link
Contributor

@lplewa lplewa commented Jul 17, 2025

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used
  • All API changes are reflected in docs and def/map files, and are tested

@lplewa lplewa requested a review from a team as a code owner July 17, 2025 11:37
@bratpiorka bratpiorka changed the base branch from main to v1.0.x July 17, 2025 12:28
#include <umf/memory_provider_ops.h>
#include <umf/providers/provider_file_memory.h>

#include "provider_ctl_stats_type.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this include

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bratpiorka bratpiorka requested a review from Copilot July 17, 2025 13:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds control statistics (ctl_stats) support to the remaining memory providers in the UMF (Unified Memory Framework) library. The implementation enables tracking of allocated memory, peak memory usage, and provides a reset mechanism for peak memory statistics across all provider types.

  • Extends ctl_stats functionality to CUDA, Level Zero, file memory, devdax memory, OS memory, and fixed memory providers
  • Adds comprehensive test coverage for ctl_stats functionality across all provider types
  • Implements consistent memory tracking and peak memory reset operations for all providers

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/provider/provider_cuda.c Adds ctl_stats implementation with memory tracking in alloc/free operations
src/provider/provider_level_zero.c Implements helper functions to enable/disable stats tracking and adds ctl_stats support
src/provider/provider_file_memory.c Integrates ctl_stats tracking into coarse allocation/deallocation operations
src/provider/provider_devdax_memory.c Adds ctl_stats support with memory tracking in devdax provider operations
test/provider_os_memory.cpp Adds comprehensive ctl_stats test coverage for OS memory provider
test/provider_fixed_memory.cpp Implements ctl_stats test suite for fixed memory provider
test/provider_file_memory.cpp Adds ctl_stats testing for file memory provider
test/provider_devdax_memory.cpp Implements ctl_stats test coverage for devdax memory provider
test/providers/provider_cuda.cpp Adds comprehensive ctl_stats test suite for CUDA provider
test/providers/provider_level_zero.cpp Implements ctl_stats testing for Level Zero provider

@bratpiorka bratpiorka requested a review from KFilipek July 17, 2025 14:23
@KFilipek KFilipek merged commit fc9a936 into oneapi-src:v1.0.x Jul 18, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants