Skip to content

Add assert in poolCreateExtUnique() after EXPECT_*() #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

Add assert in poolCreateExtUnique() after EXPECT_*() #1463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/poolFixtures.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ umf_test::pool_unique_handle_t poolCreateExtUnique(poolCreateExtParams params) {
&upstream_provider);
EXPECT_EQ(ret, UMF_RESULT_SUCCESS);
EXPECT_NE(upstream_provider, nullptr);
if (ret != UMF_RESULT_SUCCESS || upstream_provider == nullptr) {
assert(false && "Failed to create a memory provider");
return umf_test::pool_unique_handle_t(nullptr, nullptr);
}

provider = upstream_provider;

Expand All @@ -54,6 +58,10 @@ umf_test::pool_unique_handle_t poolCreateExtUnique(poolCreateExtParams params) {
UMF_POOL_CREATE_FLAG_OWN_PROVIDER, &hPool);
EXPECT_EQ(ret, UMF_RESULT_SUCCESS);
EXPECT_NE(hPool, nullptr);
if (ret != UMF_RESULT_SUCCESS || hPool == nullptr) {
assert(false && "Failed to create a memory pool");
return umf_test::pool_unique_handle_t(nullptr, nullptr);
}

// we do not need params anymore
if (poolParamsDestroy) {
Expand Down