Skip to content

set fixed iteration count for benchmarks #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2024
Merged

set fixed iteration count for benchmarks #982

merged 1 commit into from
Dec 9, 2024

Conversation

@lplewa
Copy link
Contributor

@lplewa lplewa commented Dec 9, 2024 •
edited by lukaszstolarczuk
Loading

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

ref. #786

@lplewa lplewa requested a review from a team as a code owner December 9, 2024 12:58
@bratpiorka
Copy link
Contributor

bratpiorka commented Dec 9, 2024

Agreed as a temporary solution, as all these fixed numbers should be parameters.

@lukaszstolarczuk
Copy link
Contributor

lukaszstolarczuk commented Dec 9, 2024

Agreed as a temporary solution, as all these fixed numbers should be parameters.

then at least it would be nice to have a TODO in the code 😉

@lplewa
Copy link
Contributor Author

lplewa commented Dec 9, 2024

Agreed as a temporary solution, as all these fixed numbers should be parameters.

then at least it would be nice to have a TODO in the code 😉

we have issue which list features for benchmark and this thing is there

pbalcer
pbalcer approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but please create a ticket to add CLI options to set the iterations.

@lukaszstolarczuk lukaszstolarczuk merged commit 524354b into oneapi-src:main Dec 9, 2024
153 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbalcer pbalcer pbalcer approved these changes

@bratpiorka bratpiorka bratpiorka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lplewa @bratpiorka @lukaszstolarczuk @pbalcer