Skip to content

Commit 0e20fcc

Browse files
blenderfreakybb-ur
authored andcommitted
Update PYTHON_EXECUTABLE to Python3_EXECUTABLE in cmake (#19637)
`${Python3_EXECUTABLE}` is what is set by FindPython3 and is what is used everywhere else. `${PYTHON_EXECUTABLE}` may be unset depending, causing the build to fail. This failure case gets hit when compiling under NixOS for example There's a few instances of `PYTHON_EXECUTABLE` left in upstream LLVM, though I haven't verified whether it builds properly with those changed to `Python3_EXECUTABLE`, so they're untouched here.
1 parent 633e159 commit 0e20fcc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

cmake/helpers.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ function(configure_linker_file input output)
279279
configure_file(${input} ${tmp} ${ARGN})
280280
# Strip guarded lines and capture stripped content from stdout
281281
execute_process(
282-
COMMAND ${PYTHON_EXECUTABLE}
282+
COMMAND ${Python3_EXECUTABLE}
283283
${PROJECT_SOURCE_DIR}/scripts/strip-guarded-lines.py ${tmp}
284284
# List names of guarded blocks to include in the output file here
285285
OUTPUT_VARIABLE stripped

0 commit comments

Comments
 (0)