Add numDevices == 0 condition

Author: againull

include/ur_api.h

@@ -4235,6 +4235,7 @@ urProgramCreateWithIL(
 ///         + `NULL != pProperties && pProperties->count > 0 && NULL == pProperties->pMetadatas`
 ///     - ::UR_RESULT_ERROR_INVALID_SIZE
 ///         + `NULL != pProperties && NULL != pProperties->pMetadatas && pProperties->count == 0`
+///         + `numDevices == 0`
 ///     - ::UR_RESULT_ERROR_INVALID_NATIVE_BINARY
 ///         + If any binary in `ppBinaries` isn't a valid binary for the corresponding device in `phDevices.`
 UR_APIEXPORT ur_result_t UR_APICALL

scripts/core/program.yml

@@ -158,6 +158,7 @@ returns:
         - "`NULL != pProperties && pProperties->count > 0 && NULL == pProperties->pMetadatas`"
     - $X_RESULT_ERROR_INVALID_SIZE:
         - "`NULL != pProperties && NULL != pProperties->pMetadatas && pProperties->count == 0`"
+        - "`numDevices == 0`"
     - $X_RESULT_ERROR_INVALID_NATIVE_BINARY:
         - "If any binary in `ppBinaries` isn't a valid binary for the corresponding device in `phDevices.`"
 --- #--------------------------------------------------------------------------

source/adapters/cuda/program.cpp

@@ -500,9 +500,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urProgramCreateWithBinary(
   if (numDevices > 1)
     return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
 
-  if (numDevices == 0)
-    return UR_RESULT_ERROR_INVALID_DEVICE;
-
   UR_CHECK_ERROR(createProgram(hContext, phDevices[0], pLengths[0],
                                ppBinaries[0], pProperties, phProgram));
   (*phProgram)->BinaryType = UR_PROGRAM_BINARY_TYPE_COMPILED_OBJECT;

source/adapters/hip/program.cpp

@@ -487,9 +487,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urProgramCreateWithBinary(
   if (numDevices > 1)
     return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
 
-  if (numDevices == 0)
-    return UR_RESULT_ERROR_INVALID_DEVICE;
-
   auto hDevice = phDevices[0];
   auto pBinary = ppBinaries[0];
   auto size = pLengths[0];

source/adapters/level_zero/program.hpp

@@ -106,8 +106,8 @@ struct ur_program_handle_t_ : _ur_object {
   ur_program_handle_t_(state, ur_context_handle_t Context,
                        ze_module_handle_t InteropZeModule)
       : Context{Context}, NativeProperties{nullptr}, OwnZeModule{true},
-        AssociatedDevices({Context->getDevices()[0]}),
-        InteropZeModule{InteropZeModule} {}
+        AssociatedDevices({Context->getDevices()[0]}), InteropZeModule{
+                                                           InteropZeModule} {}
 
   // Construct a program in Exe state (interop).
   // TODO: Currently it is not possible to get the device associated with the
@@ -117,8 +117,8 @@ struct ur_program_handle_t_ : _ur_object {
   ur_program_handle_t_(state, ur_context_handle_t Context,
                        ze_module_handle_t InteropZeModule, bool OwnZeModule)
       : Context{Context}, NativeProperties{nullptr}, OwnZeModule{OwnZeModule},
-        AssociatedDevices({Context->getDevices()[0]}),
-        InteropZeModule{InteropZeModule} {
+        AssociatedDevices({Context->getDevices()[0]}), InteropZeModule{
+                                                           InteropZeModule} {
     // TODO: Currently it is not possible to understand the device associated
     // with provided ZeModule. So we can't set the state on that device to Exe.
   }

source/adapters/native_cpu/program.cpp

@@ -61,9 +61,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urProgramCreateWithBinary(
   if (numDevices > 1)
     return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
 
-  if (numDevices == 0)
-    return UR_RESULT_ERROR_INVALID_DEVICE;
-
   auto hDevice = phDevices[0];
   auto pBinary = ppBinaries[0];
   std::ignore = pLengths;

source/loader/layers/validation/ur_valddi.cpp

@@ -2773,6 +2773,10 @@ __urdlllocal ur_result_t UR_APICALL urProgramCreateWithBinary(
             pProperties->count == 0) {
             return UR_RESULT_ERROR_INVALID_SIZE;
         }
+
+        if (numDevices == 0) {
+            return UR_RESULT_ERROR_INVALID_SIZE;
+        }
     }
 
     if (getContext()->enableLifetimeValidation &&

source/loader/ur_libapi.cpp

@@ -3029,6 +3029,7 @@ ur_result_t UR_APICALL urProgramCreateWithIL(
 ///         + `NULL != pProperties && pProperties->count > 0 && NULL == pProperties->pMetadatas`
 ///     - ::UR_RESULT_ERROR_INVALID_SIZE
 ///         + `NULL != pProperties && NULL != pProperties->pMetadatas && pProperties->count == 0`
+///         + `numDevices == 0`
 ///     - ::UR_RESULT_ERROR_INVALID_NATIVE_BINARY
 ///         + If any binary in `ppBinaries` isn't a valid binary for the corresponding device in `phDevices.`
 ur_result_t UR_APICALL urProgramCreateWithBinary(

source/ur_api.cpp

@@ -2596,6 +2596,7 @@ ur_result_t UR_APICALL urProgramCreateWithIL(
 ///         + `NULL != pProperties && pProperties->count > 0 && NULL == pProperties->pMetadatas`
 ///     - ::UR_RESULT_ERROR_INVALID_SIZE
 ///         + `NULL != pProperties && NULL != pProperties->pMetadatas && pProperties->count == 0`
+///         + `numDevices == 0`
 ///     - ::UR_RESULT_ERROR_INVALID_NATIVE_BINARY
 ///         + If any binary in `ppBinaries` isn't a valid binary for the corresponding device in `phDevices.`
 ur_result_t UR_APICALL urProgramCreateWithBinary(