Skip to content

Commit 8e94ada

Browse files
JackAKirkldrumm
authored andcommitted
Fix CI warnings.
hip -> HIP in comment. Signed-off-by: JackAKirk <[email protected]>
1 parent 26e2710 commit 8e94ada

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

source/adapters/hip/context.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,9 @@ urContextRetain(ur_context_handle_t hContext) {
108108
return UR_RESULT_SUCCESS;
109109
}
110110

111-
UR_APIEXPORT ur_result_t UR_APICALL urContextGetNativeHandle(
112-
ur_context_handle_t hContext, ur_native_handle_t *phNativeContext) {
111+
UR_APIEXPORT ur_result_t UR_APICALL
112+
urContextGetNativeHandle([[maybe_unused]] ur_context_handle_t hContext,
113+
ur_native_handle_t *phNativeContext) {
113114
// FIXME: this entry point has been deprecated in the SYCL RT and should be
114115
// changed to unsupported once the deprecation period has elapsed
115116
// The below is extremely dodgy but is the equivalent for what went before
@@ -119,7 +120,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urContextGetNativeHandle(
119120
// devices and is meaningless for our purposes; all hipCtx_t APIs were added
120121
// for cuda compatibility only and are deprecated by HIP.
121122

122-
hipCtx_t *Ctx;
123+
hipCtx_t *Ctx = nullptr;
123124
UR_CHECK_ERROR(hipCtxGetCurrent(Ctx));
124125
*phNativeContext = reinterpret_cast<ur_native_handle_t>(Ctx);
125126
return UR_RESULT_SUCCESS;

source/adapters/hip/device.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ int getAttribute(ur_device_handle_t Device, hipDeviceAttribute_t Attribute);
9595
namespace {
9696
/// Scoped Device is used across all UR HIP plugin implementation to activate
9797
/// the native Device on the current thread. The ScopedDevice does not
98-
/// reinstate the previous device as all operations in the hip adapter that
98+
/// reinstate the previous device as all operations in the HIP adapter that
9999
/// require an active device, set the active device and don't rely on device
100100
/// reinstation
101101
class ScopedDevice {

0 commit comments

Comments
 (0)