Merge pull request #1618 from PietroGhg/pietro/coverity_reqd

[NATIVECPU] Fix coverity warnings when handling reqd_work_group_size

Author: kbenzie

source/adapters/native_cpu/program.cpp

@@ -14,6 +14,7 @@
 #include "common/ur_util.hpp"
 #include "program.hpp"
 #include <cstdint>
+#include <memory>
 
 UR_APIEXPORT ur_result_t UR_APICALL
 urProgramCreateWithIL(ur_context_handle_t hContext, const void *pIL,
@@ -63,11 +64,11 @@ UR_APIEXPORT ur_result_t UR_APICALL urProgramCreateWithBinary(
   UR_ASSERT(phProgram, UR_RESULT_ERROR_INVALID_NULL_POINTER);
   UR_ASSERT(pBinary != nullptr, UR_RESULT_ERROR_INVALID_NULL_POINTER);
 
-  auto hProgram = new ur_program_handle_t_(
+  auto hProgram = std::make_unique<ur_program_handle_t_>(
       hContext, reinterpret_cast<const unsigned char *>(pBinary));
   if (pProperties != nullptr) {
     for (uint32_t i = 0; i < pProperties->count; i++) {
-      auto mdNode = pProperties->pMetadatas[i];
+      const auto &mdNode = pProperties->pMetadatas[i];
       std::string mdName(mdNode.pName);
       auto [Prefix, Tag] = splitMetadataName(mdName);
       if (Tag == __SYCL_UR_PROGRAM_METADATA_TAG_REQD_WORK_GROUP_SIZE) {
@@ -89,7 +90,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urProgramCreateWithBinary(
     nativecpu_it++;
   }
 
-  *phProgram = hProgram;
+  *phProgram = hProgram.release();
 
   return UR_RESULT_SUCCESS;
 }

source/adapters/native_cpu/program.hpp

@@ -13,6 +13,8 @@
 #include <ur_api.h>
 
 #include "context.hpp"
+
+#include <array>
 #include <map>
 
 namespace native_cpu {