Skip to content

Commit beef35a

Browse files
committed
Remove UMF from ur::common
and make a separate ur_umf static library. This way, components that do not require UMF (e.g. loader) do not need to link with it.
1 parent b0d4004 commit beef35a

File tree

8 files changed

+22
-7
lines changed

8 files changed

+22
-7
lines changed

source/adapters/cuda/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ endif()
7777
target_link_libraries(${TARGET_NAME} PRIVATE
7878
${PROJECT_NAME}::headers
7979
${PROJECT_NAME}::common
80+
${PROJECT_NAME}::umf
8081
Threads::Threads
8182
cudadrv
8283
)

source/adapters/hip/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ if("${UR_HIP_PLATFORM}" STREQUAL "AMD")
139139
target_link_libraries(${TARGET_NAME} PRIVATE
140140
${PROJECT_NAME}::headers
141141
${PROJECT_NAME}::common
142+
${PROJECT_NAME}::umf
142143
rocmdrv
143144
)
144145

@@ -173,6 +174,7 @@ elseif("${UR_HIP_PLATFORM}" STREQUAL "NVIDIA")
173174
target_link_libraries(${TARGET_NAME} PRIVATE
174175
${PROJECT_NAME}::headers
175176
${PROJECT_NAME}::common
177+
${PROJECT_NAME}::umf
176178
Threads::Threads
177179
cudadrv
178180
cudart

source/adapters/level_zero/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ endif()
147147
target_link_libraries(${TARGET_NAME} PRIVATE
148148
${PROJECT_NAME}::headers
149149
${PROJECT_NAME}::common
150+
${PROJECT_NAME}::umf
150151
LevelZeroLoader
151152
LevelZeroLoader-Headers
152153
)

source/adapters/native_cpu/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ find_package(Threads REQUIRED)
5252
target_link_libraries(${TARGET_NAME} PRIVATE
5353
${PROJECT_NAME}::headers
5454
${PROJECT_NAME}::common
55+
${PROJECT_NAME}::umf
5556
Threads::Threads
5657
)
5758

source/adapters/opencl/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ target_include_directories(${TARGET_NAME} PRIVATE
9595
target_link_libraries(${TARGET_NAME} PRIVATE
9696
${PROJECT_NAME}::headers
9797
${PROJECT_NAME}::common
98+
${PROJECT_NAME}::umf
9899
Threads::Threads
99100
${OpenCLICDLoaderLibrary}
100101
)

source/common/CMakeLists.txt

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@
44
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
55

66
add_ur_library(ur_common STATIC
7-
umf_helpers.hpp
8-
umf_pools/disjoint_pool_config_parser.cpp
9-
ur_pool_manager.hpp
107
ur_util.cpp
118
ur_util.hpp
129
$<$<PLATFORM_ID:Windows>:windows/ur_lib_loader.cpp>
@@ -51,9 +48,6 @@ FetchContent_MakeAvailable(unified-memory-framework)
5148
FetchContent_GetProperties(unified-memory-framework)
5249

5350
target_link_libraries(ur_common PUBLIC
54-
unified-memory-framework::umf
55-
unified-memory-framework::headers
56-
unified-memory-framework::disjoint_pool
5751
${CMAKE_DL_LIBS}
5852
${PROJECT_NAME}::headers
5953
)
@@ -64,3 +58,17 @@ if (UNIX)
6458
find_package(Threads REQUIRED)
6559
target_link_libraries(ur_common PUBLIC Threads::Threads)
6660
endif()
61+
62+
add_ur_library(ur_umf STATIC
63+
umf_helpers.hpp
64+
umf_pools/disjoint_pool_config_parser.cpp
65+
ur_pool_manager.hpp
66+
)
67+
68+
add_library(${PROJECT_NAME}::umf ALIAS ur_umf)
69+
70+
target_link_libraries(ur_umf PUBLIC
71+
unified-memory-framework::umf
72+
unified-memory-framework::headers
73+
unified-memory-framework::disjoint_pool
74+
)

test/adapters/cuda/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,4 @@ target_include_directories(test-adapter-cuda PRIVATE
2424
${PROJECT_SOURCE_DIR}/source/adapters/cuda
2525
)
2626

27-
target_link_libraries(test-adapter-cuda PRIVATE cudadrv)
27+
target_link_libraries(test-adapter-cuda PRIVATE cudadrv ${PROJECT_NAME}::umf)

test/usm/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ function(add_usm_test name)
1515
PRIVATE
1616
${PROJECT_NAME}::common
1717
${PROJECT_NAME}::loader
18+
${PROJECT_NAME}::umf
1819
ur_testing
1920
GTest::gtest_main)
2021
add_test(NAME usm-${name}

0 commit comments

Comments
 (0)