Skip to content

Commit c1ae337

Browse files
Georgi Mirazchiyskikbenzie
authored andcommitted
Move unsupported advice flags check at the start
1 parent c9e6c1a commit c1ae337

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

source/adapters/hip/enqueue.cpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,17 @@ void simpleGuessLocalWorkSize(size_t *ThreadsPerBlock,
8585
}
8686
}
8787

88-
ur_result_t setHipMemAdvise(const void *DevPtr, size_t Size,
88+
ur_result_t setHipMemAdvise(const void *DevPtr, const size_t Size,
8989
ur_usm_advice_flags_t URAdviceFlags,
9090
hipDevice_t Device) {
91+
// Handle unmapped memory advice flags
92+
if (URAdviceFlags &
93+
(UR_USM_ADVICE_FLAG_SET_NON_ATOMIC_MOSTLY |
94+
UR_USM_ADVICE_FLAG_CLEAR_NON_ATOMIC_MOSTLY |
95+
UR_USM_ADVICE_FLAG_BIAS_CACHED | UR_USM_ADVICE_FLAG_BIAS_UNCACHED)) {
96+
return UR_RESULT_ERROR_INVALID_ENUMERATION;
97+
}
98+
9199
using ur_to_hip_advice_t = std::pair<ur_usm_advice_flags_t, hipMemoryAdvise>;
92100

93101
static constexpr std::array<ur_to_hip_advice_t, 6>
@@ -129,14 +137,6 @@ ur_result_t setHipMemAdvise(const void *DevPtr, size_t Size,
129137
}
130138
}
131139

132-
// Handle unmapped memory advice flags
133-
if (URAdviceFlags &
134-
(UR_USM_ADVICE_FLAG_SET_NON_ATOMIC_MOSTLY |
135-
UR_USM_ADVICE_FLAG_CLEAR_NON_ATOMIC_MOSTLY |
136-
UR_USM_ADVICE_FLAG_BIAS_CACHED | UR_USM_ADVICE_FLAG_BIAS_UNCACHED)) {
137-
return UR_RESULT_ERROR_INVALID_ENUMERATION;
138-
}
139-
140140
return UR_RESULT_SUCCESS;
141141
}
142142

0 commit comments

Comments
 (0)