Skip to content

Commit c97335b

Browse files
committed
Address feedback and fix test.
1 parent 5c6744a commit c97335b

File tree

2 files changed

+19
-7
lines changed

2 files changed

+19
-7
lines changed

source/adapters/opencl/usm.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueUSMMemcpy(
358358
sizeof(cl_device_id), &SrcDevice, nullptr));
359359
CL_RETURN_ON_FAILURE(
360360
GetMemAllocInfo(CLContext, pDst, CL_MEM_ALLOC_DEVICE_INTEL,
361-
sizeof(cl_device_id), &SrcDevice, nullptr));
361+
sizeof(cl_device_id), &DstDevice, nullptr));
362362

363363
if ((SrcDevice && DstDevice) && SrcDevice != DstDevice) {
364364
cl_event HostCopyEvent = nullptr, FinalCopyEvent = nullptr;

test/conformance/enqueue/urEnqueueUSMMemcpy.cpp

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -207,12 +207,24 @@ struct urEnqueueUSMMemcpyMultiDeviceTest : uur::urAllDevicesTest {
207207
}
208208

209209
void TearDown() override {
210-
ASSERT_SUCCESS(urUSMFree(context, src_alloc));
211-
ASSERT_SUCCESS(urUSMFree(context, dst_alloc));
212-
ASSERT_SUCCESS(urUSMFree(context, host_alloc));
213-
ASSERT_SUCCESS(urQueueRelease(src_queue));
214-
ASSERT_SUCCESS(urQueueRelease(dst_queue));
215-
ASSERT_SUCCESS(urContextRelease(context));
210+
if (src_alloc) {
211+
ASSERT_SUCCESS(urUSMFree(context, src_alloc));
212+
}
213+
if (dst_alloc) {
214+
ASSERT_SUCCESS(urUSMFree(context, dst_alloc));
215+
}
216+
if (host_alloc) {
217+
ASSERT_SUCCESS(urUSMFree(context, host_alloc));
218+
}
219+
if (src_queue) {
220+
ASSERT_SUCCESS(urQueueRelease(src_queue));
221+
}
222+
if (dst_queue) {
223+
ASSERT_SUCCESS(urQueueRelease(dst_queue));
224+
}
225+
if (context) {
226+
ASSERT_SUCCESS(urContextRelease(context));
227+
}
216228
uur::urAllDevicesTest::TearDown();
217229
}
218230

0 commit comments

Comments
 (0)